Preserve explicit extension parsing errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -4,25 +4,35 @@
 from hyperbrowser.models.extension import ExtensionResponse
 
 
+def _get_type_name(value: Any) -> str:
+    return type(value).__name__
+
+
 def parse_extension_list_response_data(response_data: Any) -> List[ExtensionResponse]:
     if not isinstance(response_data, dict):
-        raise HyperbrowserError(f"Expected dict response but got {type(response_data)}")
+        raise HyperbrowserError(
+            f"Expected dict response but got {_get_type_name(response_data)}"
+        )
     if "extensions" not in response_data:
         raise HyperbrowserError(
             f"Expected 'extensions' key in response but got {response_data.keys()}"
         )
     if not isinstance(response_data["extensions"], list):
         raise HyperbrowserError(
-            f"Expected list in 'extensions' key but got {type(response_data['extensions'])}"
+            "Expected list in 'extensions' key but got "
+            f"{_get_type_name(response_data['extensions'])}"
         )
     parsed_extensions: List[ExtensionResponse] = []
     for index, extension in enumerate(response_data["extensions"]):
         if not isinstance(extension, dict):
             raise HyperbrowserError(
-                f"Expected extension object at index {index} but got {type(extension)}"
+                "Expected extension object at index "
+                f"{index} but got {_get_type_name(extension)}"
             )
         try:
             parsed_extensions.append(ExtensionResponse(**extension))
+        except HyperbrowserError:
+            raise
         except Exception as exc:
             raise HyperbrowserError(
                 f"Failed to parse extension at index {index}",

tests/test_extension_utils.py

@@ -1,5 +1,6 @@
 import pytest
 
+from hyperbrowser.client.managers import extension_utils
 from hyperbrowser.client.managers.extension_utils import (
     parse_extension_list_response_data,
 )
@@ -56,3 +57,23 @@ def test_parse_extension_list_response_data_wraps_invalid_extension_payloads():
                 ]
             }
         )
+
+
+def test_parse_extension_list_response_data_preserves_hyperbrowser_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    class _RaisingExtensionResponse:
+        def __init__(self, **kwargs):
+            _ = kwargs
+            raise HyperbrowserError("extension parse failed")
+
+    monkeypatch.setattr(
+        extension_utils,
+        "ExtensionResponse",
+        _RaisingExtensionResponse,
+    )
+
+    with pytest.raises(HyperbrowserError, match="extension parse failed") as exc_info:
+        parse_extension_list_response_data({"extensions": [{"id": "ext_1"}]})
+
+    assert exc_info.value.original_error is None