Handle JSON decode failures in transport success responses

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -1,3 +1,4 @@
+import json
 import httpx
 from typing import Optional
 
@@ -37,7 +38,7 @@ async def _handle_response(self, response: httpx.Response) -> APIResponse:
                 if not response.content:
                     return APIResponse.from_status(response.status_code)
                 return APIResponse(response.json())
-            except httpx.DecodingError as e:
+            except (httpx.DecodingError, json.JSONDecodeError, ValueError) as e:
                 if response.status_code >= 400:
                     raise HyperbrowserError(
                         response.text or "Unknown error occurred",

hyperbrowser/transport/sync.py

@@ -1,3 +1,4 @@
+import json
 import httpx
 from typing import Optional
 
@@ -25,7 +26,7 @@ def _handle_response(self, response: httpx.Response) -> APIResponse:
                 if not response.content:
                     return APIResponse.from_status(response.status_code)
                 return APIResponse(response.json())
-            except httpx.DecodingError as e:
+            except (httpx.DecodingError, json.JSONDecodeError, ValueError) as e:
                 if response.status_code >= 400:
                     raise HyperbrowserError(
                         response.text or "Unknown error occurred",

tests/test_transport_response_handling.py

@@ -0,0 +1,40 @@
+import asyncio
+
+import httpx
+
+from hyperbrowser.transport.async_transport import AsyncTransport
+from hyperbrowser.transport.sync import SyncTransport
+
+
+def _build_response(status_code: int, body: str) -> httpx.Response:
+    request = httpx.Request("GET", "https://example.com/test")
+    return httpx.Response(status_code, request=request, text=body)
+
+
+def test_sync_handle_response_with_non_json_success_body_returns_status_only():
+    transport = SyncTransport(api_key="test-key")
+    try:
+        response = _build_response(200, "plain-text-response")
+
+        api_response = transport._handle_response(response)
+
+        assert api_response.status_code == 200
+        assert api_response.data is None
+    finally:
+        transport.close()
+
+
+def test_async_handle_response_with_non_json_success_body_returns_status_only():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            response = _build_response(200, "plain-text-response")
+
+            api_response = await transport._handle_response(response)
+
+            assert api_response.status_code == 200
+            assert api_response.data is None
+        finally:
+            await transport.close()
+
+    asyncio.run(run())