Simplify file-path error helper default prefix handling

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/file_utils.py

@@ -1,7 +1,7 @@
 import os
 from contextlib import contextmanager
 from os import PathLike
-from typing import BinaryIO, Iterator, Union
+from typing import BinaryIO, Iterator, Optional, Union
 
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.type_utils import is_plain_int, is_plain_string
@@ -76,9 +76,12 @@ def build_file_path_error_message(
     file_path: object,
     *,
     prefix: str,
-    default_prefix: str,
+    default_prefix: Optional[str] = None,
 ) -> str:
-    normalized_prefix = _normalize_error_prefix(prefix, default_prefix=default_prefix)
+    normalized_prefix = _normalize_error_prefix(
+        prefix,
+        default_prefix=prefix if default_prefix is None else default_prefix,
+    )
     file_path_display = format_file_path_for_error(file_path)
     return f"{normalized_prefix}: {file_path_display}"
 

hyperbrowser/client/managers/extension_create_utils.py

@@ -31,12 +31,10 @@ def normalize_extension_create_input(params: Any) -> Tuple[str, Dict[str, Any]]:
         missing_file_message=build_file_path_error_message(
             raw_file_path,
             prefix="Extension file not found at path",
-            default_prefix="Extension file not found at path",
         ),
         not_file_message=build_file_path_error_message(
             raw_file_path,
             prefix="Extension file path must point to a file",
-            default_prefix="Extension file path must point to a file",
         ),
     )
     return file_path, payload

hyperbrowser/client/managers/session_upload_utils.py

@@ -32,12 +32,10 @@ def normalize_upload_file_input(
             missing_file_message=build_file_path_error_message(
                 raw_file_path,
                 prefix="Upload file not found at path",
-                default_prefix="Upload file not found at path",
             ),
             not_file_message=build_file_path_error_message(
                 raw_file_path,
                 prefix="Upload file path must point to a file",
-                default_prefix="Upload file path must point to a file",
             ),
         )
         return file_path, None

tests/test_file_utils.py

@@ -342,6 +342,15 @@ def test_build_file_path_error_message_uses_prefix_and_sanitized_path():
     assert message == "Upload file not found at path: bad?path.txt"
 
 
+def test_build_file_path_error_message_defaults_default_prefix_to_prefix():
+    message = build_file_path_error_message(
+        "bad\tpath.txt",
+        prefix="Upload file not found at path",
+    )
+
+    assert message == "Upload file not found at path: bad?path.txt"
+
+
 def test_build_file_path_error_message_uses_default_for_non_string_prefix():
     message = build_file_path_error_message(
         "/tmp/path.txt",