Reject non-integer transport response status codes

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -43,9 +43,9 @@ def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
     def _normalize_response_status_code(self, response: httpx.Response) -> int:
         try:
             status_code = response.status_code
-            if isinstance(status_code, bool):
-                raise TypeError("boolean status code is invalid")
-            normalized_status_code = int(status_code)
+            if isinstance(status_code, bool) or not isinstance(status_code, int):
+                raise TypeError("status code must be an integer")
+            normalized_status_code = status_code
             if not (
                 self._MIN_HTTP_STATUS_CODE
                 <= normalized_status_code

hyperbrowser/transport/sync.py

@@ -42,9 +42,9 @@ def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
     def _normalize_response_status_code(self, response: httpx.Response) -> int:
         try:
             status_code = response.status_code
-            if isinstance(status_code, bool):
-                raise TypeError("boolean status code is invalid")
-            normalized_status_code = int(status_code)
+            if isinstance(status_code, bool) or not isinstance(status_code, int):
+                raise TypeError("status code must be an integer")
+            normalized_status_code = status_code
             if not (
                 self._MIN_HTTP_STATUS_CODE
                 <= normalized_status_code

tests/test_transport_response_handling.py

@@ -92,6 +92,20 @@ def json(self):
         return {}
 
 
+class _NonIntegerStatusNoContentResponse:
+    content = b""
+    text = ""
+
+    def __init__(self, status_code):
+        self.status_code = status_code
+
+    def raise_for_status(self) -> None:
+        return None
+
+    def json(self):
+        return {}
+
+
 class _BrokenStatusCodeHttpErrorResponse:
     content = b""
     text = "status error"
@@ -201,6 +215,22 @@ def test_sync_handle_response_with_out_of_range_status_raises_hyperbrowser_error
         transport.close()
 
 
+@pytest.mark.parametrize("status_code", ["200", 200.0])
+def test_sync_handle_response_with_non_integer_status_raises_hyperbrowser_error(
+    status_code,
+):
+    transport = SyncTransport(api_key="test-key")
+    try:
+        with pytest.raises(
+            HyperbrowserError, match="Failed to process response status code"
+        ):
+            transport._handle_response(
+                _NonIntegerStatusNoContentResponse(status_code)  # type: ignore[arg-type]
+            )
+    finally:
+        transport.close()
+
+
 def test_sync_handle_response_with_request_error_includes_method_and_url():
     transport = SyncTransport(api_key="test-key")
     try:
@@ -371,6 +401,25 @@ async def run() -> None:
     asyncio.run(run())
 
 
+@pytest.mark.parametrize("status_code", ["200", 200.0])
+def test_async_handle_response_with_non_integer_status_raises_hyperbrowser_error(
+    status_code,
+):
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Failed to process response status code"
+            ):
+                await transport._handle_response(
+                    _NonIntegerStatusNoContentResponse(status_code)  # type: ignore[arg-type]
+                )
+        finally:
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_handle_response_with_request_error_includes_method_and_url():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")