Skip to content

Commit 30a391c

Browse files
Use pathlib.Path type for extension upload params
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent f9001e7 commit 30a391c

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

hyperbrowser/models/extension.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from datetime import datetime
2+
from pathlib import Path
23
from typing import Optional
34
from pydantic import BaseModel, ConfigDict, Field
45

@@ -13,7 +14,7 @@ class CreateExtensionParams(BaseModel):
1314
)
1415

1516
name: Optional[str] = Field(default=None, serialization_alias="name")
16-
file_path: str = Field(serialization_alias="filePath")
17+
file_path: Path = Field(serialization_alias="filePath")
1718

1819

1920
class ExtensionResponse(BaseModel):

tests/test_extension_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ def _build_url(self, path: str) -> str:
6565
return f"https://api.hyperbrowser.ai/api{path}"
6666

6767

68-
def _create_test_extension_zip(tmp_path: Path) -> str:
68+
def _create_test_extension_zip(tmp_path: Path) -> Path:
6969
file_path = tmp_path / "extension.zip"
7070
file_path.write_bytes(b"extension-bytes")
71-
return str(file_path)
71+
return file_path
7272

7373

7474
def test_sync_extension_create_does_not_mutate_params_and_closes_file(tmp_path):

0 commit comments

Comments
 (0)