Require plain CreateExtensionParams in extension managers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -12,7 +12,7 @@ def __init__(self, client):
         self._client = client
 
     async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
-        if not isinstance(params, CreateExtensionParams):
+        if type(params) is not CreateExtensionParams:
             raise HyperbrowserError("params must be CreateExtensionParams")
         try:
             raw_file_path = params.file_path

hyperbrowser/client/managers/sync_manager/extension.py

@@ -12,7 +12,7 @@ def __init__(self, client):
         self._client = client
 
     def create(self, params: CreateExtensionParams) -> ExtensionResponse:
-        if not isinstance(params, CreateExtensionParams):
+        if type(params) is not CreateExtensionParams:
             raise HyperbrowserError("params must be CreateExtensionParams")
         try:
             raw_file_path = params.file_path

tests/test_extension_manager.py

@@ -221,12 +221,9 @@ def test_sync_extension_create_rejects_invalid_params_type():
         manager.create({"name": "bad", "filePath": "/tmp/ext.zip"})  # type: ignore[arg-type]
 
 
-def test_sync_extension_create_wraps_invalid_params_file_path_state(tmp_path):
+def test_sync_extension_create_rejects_subclass_params(tmp_path):
     class _BrokenParams(CreateExtensionParams):
-        def __getattribute__(self, item: str):
-            if item == "file_path":
-                raise RuntimeError("broken file_path state")
-            return super().__getattribute__(item)
+        pass
 
     manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
     params = _BrokenParams(
@@ -235,28 +232,7 @@ def __getattribute__(self, item: str):
     )
 
     with pytest.raises(
-        HyperbrowserError, match="params.file_path is invalid"
-    ) as exc_info:
-        manager.create(params)
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_sync_extension_create_preserves_hyperbrowser_file_path_state_errors(tmp_path):
-    class _BrokenParams(CreateExtensionParams):
-        def __getattribute__(self, item: str):
-            if item == "file_path":
-                raise HyperbrowserError("custom file_path state failure")
-            return super().__getattribute__(item)
-
-    manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
-    params = _BrokenParams(
-        name="bad-extension",
-        file_path=_create_test_extension_zip(tmp_path),
-    )
-
-    with pytest.raises(
-        HyperbrowserError, match="custom file_path state failure"
+        HyperbrowserError, match="params must be CreateExtensionParams"
     ) as exc_info:
         manager.create(params)
 
@@ -293,12 +269,9 @@ async def run():
     asyncio.run(run())
 
 
-def test_async_extension_create_wraps_invalid_params_file_path_state(tmp_path):
+def test_async_extension_create_rejects_subclass_params(tmp_path):
     class _BrokenParams(CreateExtensionParams):
-        def __getattribute__(self, item: str):
-            if item == "file_path":
-                raise RuntimeError("broken file_path state")
-            return super().__getattribute__(item)
+        pass
 
     manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
     params = _BrokenParams(
@@ -308,30 +281,7 @@ def __getattribute__(self, item: str):
 
     async def run():
         with pytest.raises(
-            HyperbrowserError, match="params.file_path is invalid"
-        ) as exc_info:
-            await manager.create(params)
-        assert isinstance(exc_info.value.original_error, RuntimeError)
-
-    asyncio.run(run())
-
-
-def test_async_extension_create_preserves_hyperbrowser_file_path_state_errors(tmp_path):
-    class _BrokenParams(CreateExtensionParams):
-        def __getattribute__(self, item: str):
-            if item == "file_path":
-                raise HyperbrowserError("custom file_path state failure")
-            return super().__getattribute__(item)
-
-    manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
-    params = _BrokenParams(
-        name="bad-extension",
-        file_path=_create_test_extension_zip(tmp_path),
-    )
-
-    async def run():
-        with pytest.raises(
-            HyperbrowserError, match="custom file_path state failure"
+            HyperbrowserError, match="params must be CreateExtensionParams"
         ) as exc_info:
             await manager.create(params)
         assert exc_info.value.original_error is None