Require concrete transport model-name render outputs

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/base.py

@@ -18,7 +18,7 @@ def _sanitize_display_text(value: str, *, max_length: int) -> str:
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in value
         ).strip()
-        if not isinstance(sanitized_value, str):
+        if type(sanitized_value) is not str:
             return ""
         if not sanitized_value:
             return ""
@@ -37,7 +37,7 @@ def _safe_model_name(model: object) -> str:
         model_name = getattr(model, "__name__", "response model")
     except Exception:
         return "response model"
-    if not isinstance(model_name, str):
+    if type(model_name) is not str:
         return "response model"
     try:
         normalized_model_name = _sanitize_display_text(

tests/test_transport_base.py

@@ -114,6 +114,17 @@ def __call__(self, **kwargs):
         raise RuntimeError("call failed")
 
 
+class _StringSubclassModelNameCallableModel:
+    class _ModelName(str):
+        pass
+
+    __name__ = _ModelName("SubclassModelName")
+
+    def __call__(self, **kwargs):
+        _ = kwargs
+        raise RuntimeError("call failed")
+
+
 class _BrokenRenderedMappingKey(str):
     def __iter__(self):
         raise RuntimeError("cannot iterate rendered mapping key")
@@ -250,6 +261,17 @@ def test_api_response_from_json_falls_back_for_unreadable_model_name_text() -> N
         )
 
 
+def test_api_response_from_json_falls_back_for_string_subclass_model_names() -> None:
+    with pytest.raises(
+        HyperbrowserError,
+        match="Failed to parse response data for response model",
+    ):
+        APIResponse.from_json(
+            {"name": "job-1"},
+            cast("type[_SampleResponseModel]", _StringSubclassModelNameCallableModel()),
+        )
+
+
 def test_api_response_from_json_uses_placeholder_for_blank_mapping_key_in_errors() -> (
     None
 ):