Use HyperbrowserError in computer action endpoint checks

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/computer_action.py

@@ -1,5 +1,6 @@
 from pydantic import BaseModel
 from typing import Union, List, Optional
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     SessionDetail,
     ComputerActionParams,
@@ -32,7 +33,9 @@ async def _execute_request(
             session = await self._client.sessions.get(session)
 
         if not session.computer_action_endpoint:
-            raise ValueError("Computer action endpoint not available for this session")
+            raise HyperbrowserError(
+                "Computer action endpoint not available for this session"
+            )
 
         if isinstance(params, BaseModel):
             payload = params.model_dump(by_alias=True, exclude_none=True)

hyperbrowser/client/managers/sync_manager/computer_action.py

@@ -1,5 +1,6 @@
 from pydantic import BaseModel
 from typing import Union, List, Optional
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     SessionDetail,
     ComputerActionParams,
@@ -32,7 +33,9 @@ def _execute_request(
             session = self._client.sessions.get(session)
 
         if not session.computer_action_endpoint:
-            raise ValueError("Computer action endpoint not available for this session")
+            raise HyperbrowserError(
+                "Computer action endpoint not available for this session"
+            )
 
         if isinstance(params, BaseModel):
             payload = params.model_dump(by_alias=True, exclude_none=True)

tests/test_computer_action_manager.py

@@ -0,0 +1,41 @@
+import asyncio
+from types import SimpleNamespace
+
+import pytest
+
+from hyperbrowser.client.managers.async_manager.computer_action import (
+    ComputerActionManager as AsyncComputerActionManager,
+)
+from hyperbrowser.client.managers.sync_manager.computer_action import (
+    ComputerActionManager as SyncComputerActionManager,
+)
+from hyperbrowser.exceptions import HyperbrowserError
+
+
+class _DummyClient:
+    def __init__(self) -> None:
+        self.sessions = None
+        self.transport = None
+
+
+def test_sync_computer_action_manager_raises_hyperbrowser_error_without_endpoint():
+    manager = SyncComputerActionManager(_DummyClient())
+    session = SimpleNamespace(computer_action_endpoint=None)
+
+    with pytest.raises(
+        HyperbrowserError, match="Computer action endpoint not available"
+    ):
+        manager.screenshot(session)
+
+
+def test_async_computer_action_manager_raises_hyperbrowser_error_without_endpoint():
+    async def run() -> None:
+        manager = AsyncComputerActionManager(_DummyClient())
+        session = SimpleNamespace(computer_action_endpoint=None)
+
+        with pytest.raises(
+            HyperbrowserError, match="Computer action endpoint not available"
+        ):
+            await manager.screenshot(session)
+
+    asyncio.run(run())