Reject string-subclass session timestamp inputs

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/models/session.py

@@ -144,8 +144,10 @@ def parse_timestamp(cls, value: Optional[Union[str, int]]) -> Optional[int]:
         """Convert string timestamps to integers."""
         if value is None:
             return None
-        if isinstance(value, str):
+        if type(value) is str:
             return int(value)
+        if isinstance(value, str):
+            raise ValueError("timestamp string values must be plain strings")
         return value
 
 

tests/test_session_models.py

@@ -0,0 +1,40 @@
+import pytest
+from pydantic import ValidationError
+
+from hyperbrowser.models.session import Session
+
+
+def _build_session_payload() -> dict:
+    return {
+        "id": "session-1",
+        "teamId": "team-1",
+        "status": "active",
+        "createdAt": "2025-01-01T00:00:00Z",
+        "updatedAt": "2025-01-01T00:00:00Z",
+        "sessionUrl": "https://example.com/session/1",
+        "proxyDataConsumed": "0",
+    }
+
+
+def test_session_model_converts_plain_string_timestamps_to_int():
+    payload = _build_session_payload()
+    payload["startTime"] = "1735689600"
+    payload["endTime"] = "1735689660"
+
+    model = Session.model_validate(payload)
+
+    assert model.start_time == 1735689600
+    assert model.end_time == 1735689660
+
+
+def test_session_model_rejects_string_subclass_timestamps():
+    class _TimestampString(str):
+        pass
+
+    payload = _build_session_payload()
+    payload["startTime"] = _TimestampString("1735689600")
+
+    with pytest.raises(
+        ValidationError, match="timestamp string values must be plain strings"
+    ):
+        Session.model_validate(payload)