Wrap PathLike fspath runtime failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/file_utils.py

@@ -13,11 +13,15 @@ def ensure_existing_file_path(
 ) -> str:
     try:
         normalized_path = os.fspath(file_path)
+    except HyperbrowserError:
+        raise
     except TypeError as exc:
         raise HyperbrowserError(
             "file_path must be a string or os.PathLike object",
             original_error=exc,
         ) from exc
+    except Exception as exc:
+        raise HyperbrowserError("file_path is invalid", original_error=exc) from exc
     if not isinstance(normalized_path, str):
         raise HyperbrowserError("file_path must resolve to a string path")
     if not normalized_path.strip():

tests/test_file_utils.py

@@ -134,3 +134,33 @@ def raising_exists(path: str) -> bool:
             missing_file_message="missing",
             not_file_message="not-file",
         )
+
+
+def test_ensure_existing_file_path_wraps_fspath_runtime_errors():
+    class _BrokenPathLike:
+        def __fspath__(self) -> str:
+            raise RuntimeError("bad fspath")
+
+    with pytest.raises(HyperbrowserError, match="file_path is invalid") as exc_info:
+        ensure_existing_file_path(
+            _BrokenPathLike(),  # type: ignore[arg-type]
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is not None
+
+
+def test_ensure_existing_file_path_preserves_hyperbrowser_fspath_errors():
+    class _BrokenPathLike:
+        def __fspath__(self) -> str:
+            raise HyperbrowserError("custom fspath failure")
+
+    with pytest.raises(HyperbrowserError, match="custom fspath failure") as exc_info:
+        ensure_existing_file_path(
+            _BrokenPathLike(),  # type: ignore[arg-type]
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is None