Validate base_url format and avoid double /api paths

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/base.py

@@ -49,4 +49,6 @@ def __init__(
 
     def _build_url(self, path: str) -> str:
         normalized_path = path if path.startswith("/") else f"/{path}"
+        if normalized_path == "/api" or normalized_path.startswith("/api/"):
+            return f"{self.config.base_url}{normalized_path}"
         return f"{self.config.base_url}/api{normalized_path}"

hyperbrowser/config.py

@@ -20,6 +20,15 @@ def __post_init__(self) -> None:
             raise HyperbrowserError("base_url must be a string")
         self.api_key = self.api_key.strip()
         self.base_url = self.base_url.strip().rstrip("/")
+        if not self.base_url:
+            raise HyperbrowserError("base_url must not be empty")
+        if not (
+            self.base_url.startswith("https://")
+            or self.base_url.startswith("http://")
+        ):
+            raise HyperbrowserError(
+                "base_url must start with 'https://' or 'http://'"
+            )
 
     @classmethod
     def from_env(cls) -> "ClientConfig":

tests/test_config.py

@@ -41,3 +41,11 @@ def test_client_config_rejects_non_string_values():
 
     with pytest.raises(HyperbrowserError, match="base_url must be a string"):
         ClientConfig(api_key="test-key", base_url=None)  # type: ignore[arg-type]
+
+
+def test_client_config_rejects_empty_or_invalid_base_url():
+    with pytest.raises(HyperbrowserError, match="base_url must not be empty"):
+        ClientConfig(api_key="test-key", base_url="   ")
+
+    with pytest.raises(HyperbrowserError, match="base_url must start with"):
+        ClientConfig(api_key="test-key", base_url="api.hyperbrowser.ai")

tests/test_url_building.py

@@ -7,6 +7,7 @@ def test_client_build_url_normalizes_leading_slash():
     try:
         assert client._build_url("/session") == "https://api.hyperbrowser.ai/api/session"
         assert client._build_url("session") == "https://api.hyperbrowser.ai/api/session"
+        assert client._build_url("/api/session") == "https://api.hyperbrowser.ai/api/session"
     finally:
         client.close()