Require concrete session ID strings in computer-action managers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/computer_action.py

@@ -30,8 +30,12 @@ def __init__(self, client):
     async def _execute_request(
         self, session: Union[SessionDetail, str], params: ComputerActionParams
     ) -> ComputerActionResponse:
-        if isinstance(session, str):
+        if type(session) is str:
             session = await self._client.sessions.get(session)
+        elif isinstance(session, str):
+            raise HyperbrowserError(
+                "session must be a plain string session ID or SessionDetail"
+            )
 
         if not session.computer_action_endpoint:
             raise HyperbrowserError(

hyperbrowser/client/managers/sync_manager/computer_action.py

@@ -30,8 +30,12 @@ def __init__(self, client):
     def _execute_request(
         self, session: Union[SessionDetail, str], params: ComputerActionParams
     ) -> ComputerActionResponse:
-        if isinstance(session, str):
+        if type(session) is str:
             session = self._client.sessions.get(session)
+        elif isinstance(session, str):
+            raise HyperbrowserError(
+                "session must be a plain string session ID or SessionDetail"
+            )
 
         if not session.computer_action_endpoint:
             raise HyperbrowserError(

tests/test_computer_action_manager.py

@@ -39,3 +39,31 @@ async def run() -> None:
             await manager.screenshot(session)
 
     asyncio.run(run())
+
+
+def test_sync_computer_action_manager_rejects_string_subclass_session_ids():
+    class _SessionId(str):
+        pass
+
+    manager = SyncComputerActionManager(_DummyClient())
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="session must be a plain string session ID or SessionDetail",
+    ):
+        manager.screenshot(_SessionId("sess_123"))
+
+
+def test_async_computer_action_manager_rejects_string_subclass_session_ids():
+    class _SessionId(str):
+        pass
+
+    async def run() -> None:
+        manager = AsyncComputerActionManager(_DummyClient())
+        with pytest.raises(
+            HyperbrowserError,
+            match="session must be a plain string session ID or SessionDetail",
+        ):
+            await manager.screenshot(_SessionId("sess_123"))
+
+    asyncio.run(run())