Require callable read() for file-like session uploads

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -119,7 +119,7 @@ async def upload_file(
                     self._client._build_url(f"/session/{id}/uploads"),
                     files=files,
                 )
-        elif hasattr(file_input, "read"):
+        elif callable(getattr(file_input, "read", None)):
             files = {"file": file_input}
             response = await self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),

hyperbrowser/client/managers/sync_manager/session.py

@@ -111,7 +111,7 @@ def upload_file(
                     self._client._build_url(f"/session/{id}/uploads"),
                     files=files,
                 )
-        elif hasattr(file_input, "read"):
+        elif callable(getattr(file_input, "read", None)):
             files = {"file": file_input}
             response = self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),

tests/test_session_upload_file.py

@@ -137,3 +137,22 @@ async def run():
             await manager.upload_file("session_123", 123)  # type: ignore[arg-type]
 
     asyncio.run(run())
+
+
+def test_sync_session_upload_file_rejects_non_callable_read_attribute():
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+    fake_file = type("FakeFile", (), {"read": "not-callable"})()
+
+    with pytest.raises(TypeError, match="file_input must be a file path"):
+        manager.upload_file("session_123", fake_file)
+
+
+def test_async_session_upload_file_rejects_non_callable_read_attribute():
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+    fake_file = type("FakeFile", (), {"read": "not-callable"})()
+
+    async def run():
+        with pytest.raises(TypeError, match="file_input must be a file path"):
+            await manager.upload_file("session_123", fake_file)
+
+    asyncio.run(run())