Normalize numeric URL-like fallbacks to unknown URL in transport errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -34,6 +34,9 @@ def _normalize_request_url(url: Any) -> str:
     normalized_url = raw_url.strip()
     if not normalized_url:
         return "unknown URL"
+    lowered_url = normalized_url.lower()
+    if lowered_url in {"none", "null"} or normalized_url.isdigit():
+        return "unknown URL"
     if any(character.isspace() for character in normalized_url):
         return "unknown URL"
     if any(

tests/test_transport_error_utils.py

@@ -245,6 +245,16 @@ def test_format_request_failure_message_normalizes_non_string_fallback_values():
     assert message == "Request UNKNOWN unknown URL failed"
 
 
+def test_format_request_failure_message_normalizes_numeric_fallback_url_values():
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method="GET",
+        fallback_url=123,
+    )
+
+    assert message == "Request GET unknown URL failed"
+
+
 def test_format_request_failure_message_supports_url_like_fallback_values():
     message = format_request_failure_message(
         httpx.RequestError("network down"),
@@ -264,6 +274,15 @@ def test_format_generic_request_failure_message_normalizes_invalid_url_objects()
     assert message == "Request GET unknown URL failed"
 
 
+def test_format_generic_request_failure_message_normalizes_numeric_url_values():
+    message = format_generic_request_failure_message(
+        method="GET",
+        url=123,
+    )
+
+    assert message == "Request GET unknown URL failed"
+
+
 def test_format_generic_request_failure_message_supports_url_like_values():
     message = format_generic_request_failure_message(
         method="GET",

tests/test_transport_response_handling.py

@@ -378,6 +378,22 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_wraps_unexpected_errors_with_numeric_url_fallback():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise RuntimeError("boom")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(HyperbrowserError, match="Request GET unknown URL failed"):
+            transport.get(123)  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_async_transport_put_wraps_unexpected_errors_with_url_context():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")
@@ -421,6 +437,27 @@ async def failing_put(*args, **kwargs):
     asyncio.run(run())
 
 
+def test_async_transport_wraps_unexpected_errors_with_numeric_url_fallback():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_put = transport.client.put
+
+        async def failing_put(*args, **kwargs):
+            raise RuntimeError("boom")
+
+        transport.client.put = failing_put  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Request PUT unknown URL failed"
+            ):
+                await transport.put(123)  # type: ignore[arg-type]
+        finally:
+            transport.client.put = original_put  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_sync_transport_request_error_without_request_uses_fallback_url():
     transport = SyncTransport(api_key="test-key")
     original_get = transport.client.get
@@ -473,6 +510,22 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_request_error_without_request_uses_unknown_url_for_numeric_input():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise httpx.RequestError("network down")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(HyperbrowserError, match="Request GET unknown URL failed"):
+            transport.get(123)  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_async_transport_request_error_without_request_uses_fallback_url():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")
@@ -536,3 +589,24 @@ async def failing_delete(*args, **kwargs):
             await transport.close()
 
     asyncio.run(run())
+
+
+def test_async_transport_request_error_without_request_uses_unknown_url_for_numeric_input():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_delete = transport.client.delete
+
+        async def failing_delete(*args, **kwargs):
+            raise httpx.RequestError("network down")
+
+        transport.client.delete = failing_delete  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Request DELETE unknown URL failed"
+            ):
+                await transport.delete(123)  # type: ignore[arg-type]
+        finally:
+            transport.client.delete = original_delete  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())