Wrap transport response status code processing failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -56,18 +56,28 @@ async def _handle_response(self, response: httpx.Response) -> APIResponse:
                     return APIResponse.from_status(response.status_code)
                 return APIResponse(response.json())
             except Exception as e:
-                if response.status_code >= 400:
+                try:
+                    status_code = response.status_code
+                    if isinstance(status_code, bool):
+                        raise TypeError("boolean status code is invalid")
+                    normalized_status_code = int(status_code)
+                except Exception as status_exc:
+                    raise HyperbrowserError(
+                        "Failed to process response status code",
+                        original_error=status_exc,
+                    ) from status_exc
+                if normalized_status_code >= 400:
                     try:
                         response_text = response.text
                     except Exception:
                         response_text = ""
                     raise HyperbrowserError(
                         response_text or "Unknown error occurred",
-                        status_code=response.status_code,
+                        status_code=normalized_status_code,
                         response=response,
                         original_error=e,
                     )
-                return APIResponse.from_status(response.status_code)
+                return APIResponse.from_status(normalized_status_code)
         except httpx.HTTPStatusError as e:
             message = extract_error_message(response, fallback_error=e)
             raise HyperbrowserError(

hyperbrowser/transport/sync.py

@@ -44,18 +44,28 @@ def _handle_response(self, response: httpx.Response) -> APIResponse:
                     return APIResponse.from_status(response.status_code)
                 return APIResponse(response.json())
             except Exception as e:
-                if response.status_code >= 400:
+                try:
+                    status_code = response.status_code
+                    if isinstance(status_code, bool):
+                        raise TypeError("boolean status code is invalid")
+                    normalized_status_code = int(status_code)
+                except Exception as status_exc:
+                    raise HyperbrowserError(
+                        "Failed to process response status code",
+                        original_error=status_exc,
+                    ) from status_exc
+                if normalized_status_code >= 400:
                     try:
                         response_text = response.text
                     except Exception:
                         response_text = ""
                     raise HyperbrowserError(
                         response_text or "Unknown error occurred",
-                        status_code=response.status_code,
+                        status_code=normalized_status_code,
                         response=response,
                         original_error=e,
                     )
-                return APIResponse.from_status(response.status_code)
+                return APIResponse.from_status(normalized_status_code)
         except httpx.HTTPStatusError as e:
             message = extract_error_message(response, fallback_error=e)
             raise HyperbrowserError(

tests/test_transport_response_handling.py

@@ -52,6 +52,20 @@ def json(self):
         raise RuntimeError("broken json")
 
 
+class _BrokenStatusCodeJsonResponse:
+    content = b"{broken-json}"
+
+    def raise_for_status(self) -> None:
+        return None
+
+    @property
+    def status_code(self) -> int:
+        raise RuntimeError("broken status code")
+
+    def json(self):
+        raise RuntimeError("broken json")
+
+
 def test_sync_handle_response_with_non_json_success_body_returns_status_only():
     transport = SyncTransport(api_key="test-key")
     try:
@@ -89,6 +103,20 @@ def test_sync_handle_response_with_broken_json_error_payload_uses_default_messag
         transport.close()
 
 
+def test_sync_handle_response_with_broken_status_code_raises_hyperbrowser_error():
+    transport = SyncTransport(api_key="test-key")
+    try:
+        with pytest.raises(
+            HyperbrowserError, match="Failed to process response status code"
+        ) as exc_info:
+            transport._handle_response(
+                _BrokenStatusCodeJsonResponse()  # type: ignore[arg-type]
+            )
+        assert exc_info.value.original_error is not None
+    finally:
+        transport.close()
+
+
 def test_sync_handle_response_with_request_error_includes_method_and_url():
     transport = SyncTransport(api_key="test-key")
     try:
@@ -191,6 +219,23 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_async_handle_response_with_broken_status_code_raises_hyperbrowser_error():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Failed to process response status code"
+            ) as exc_info:
+                await transport._handle_response(
+                    _BrokenStatusCodeJsonResponse()  # type: ignore[arg-type]
+                )
+            assert exc_info.value.original_error is not None
+        finally:
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_handle_response_with_request_error_includes_method_and_url():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")