Skip to content

Commit 71c5c04

Browse files
Align display max-length typing and bool boundary coverage
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent f9a6651 commit 71c5c04

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

hyperbrowser/display_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
_DEFAULT_MAX_DISPLAY_LENGTH = 200
66

77

8-
def normalize_display_text(value: object, *, max_length: int) -> str:
8+
def normalize_display_text(value: object, *, max_length: object) -> str:
99
if not is_plain_string(value):
1010
return ""
1111
if not is_plain_int(max_length) or max_length <= 0:
@@ -29,7 +29,7 @@ def normalize_display_text(value: object, *, max_length: int) -> str:
2929
return ""
3030

3131

32-
def _normalize_blank_key_fallback(*, fallback: object, max_length: int) -> str:
32+
def _normalize_blank_key_fallback(*, fallback: object, max_length: object) -> str:
3333
normalized_fallback = normalize_display_text(fallback, max_length=max_length)
3434
if normalized_fallback:
3535
return normalized_fallback
@@ -39,7 +39,7 @@ def _normalize_blank_key_fallback(*, fallback: object, max_length: int) -> str:
3939
def format_string_key_for_error(
4040
key: object,
4141
*,
42-
max_length: int,
42+
max_length: object,
4343
blank_fallback: object = _DEFAULT_BLANK_KEY_FALLBACK,
4444
) -> str:
4545
normalized_key = normalize_display_text(key, max_length=max_length)

tests/test_display_utils.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ def test_normalize_display_text_uses_default_length_for_non_positive_max_length(
4646
assert normalize_display_text("value", max_length=-10) == "value"
4747

4848

49+
def test_normalize_display_text_uses_default_length_for_bool_max_length():
50+
assert normalize_display_text("value", max_length=False) == "value"
51+
assert normalize_display_text("value", max_length=True) == "value"
52+
53+
4954
def test_format_string_key_for_error_returns_normalized_key():
5055
assert format_string_key_for_error(" \nkey\t ", max_length=20) == "?key?"
5156

@@ -59,6 +64,11 @@ def test_format_string_key_for_error_uses_default_length_for_non_positive_max_le
5964
assert format_string_key_for_error("key", max_length=-5) == "key"
6065

6166

67+
def test_format_string_key_for_error_uses_default_length_for_bool_max_length():
68+
assert format_string_key_for_error("key", max_length=False) == "key"
69+
assert format_string_key_for_error("key", max_length=True) == "key"
70+
71+
6272
def test_format_string_key_for_error_returns_blank_fallback_for_empty_keys():
6373
assert format_string_key_for_error(" ", max_length=20) == "<blank key>"
6474

0 commit comments

Comments
 (0)