Enforce exact string types for parsed URL components

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -114,11 +114,11 @@ def normalize_base_url(base_url: str) -> str:
                 original_error=exc,
             ) from exc
         if (
-            not isinstance(parsed_base_url_scheme, str)
-            or not isinstance(parsed_base_url_netloc, str)
-            or not isinstance(parsed_base_url_path, str)
-            or not isinstance(parsed_base_url_query, str)
-            or not isinstance(parsed_base_url_fragment, str)
+            type(parsed_base_url_scheme) is not str
+            or type(parsed_base_url_netloc) is not str
+            or type(parsed_base_url_path) is not str
+            or type(parsed_base_url_query) is not str
+            or type(parsed_base_url_fragment) is not str
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
         try:
@@ -130,8 +130,9 @@ def normalize_base_url(base_url: str) -> str:
                 "Failed to parse base_url host",
                 original_error=exc,
             ) from exc
-        if parsed_base_url_hostname is not None and not isinstance(
-            parsed_base_url_hostname, str
+        if (
+            parsed_base_url_hostname is not None
+            and type(parsed_base_url_hostname) is not str
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
         if (
@@ -159,12 +160,14 @@ def normalize_base_url(base_url: str) -> str:
                 "Failed to parse base_url credentials",
                 original_error=exc,
             ) from exc
-        if parsed_base_url_username is not None and not isinstance(
-            parsed_base_url_username, str
+        if (
+            parsed_base_url_username is not None
+            and type(parsed_base_url_username) is not str
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
-        if parsed_base_url_password is not None and not isinstance(
-            parsed_base_url_password, str
+        if (
+            parsed_base_url_password is not None
+            and type(parsed_base_url_password) is not str
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
         if parsed_base_url_username is not None or parsed_base_url_password is not None:

tests/test_config.py

@@ -544,6 +544,34 @@ def port(self) -> int:
         ClientConfig.normalize_base_url("https://example.local")
 
 
+def test_client_config_normalize_base_url_rejects_string_subclass_components(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    class _WeirdString(str):
+        pass
+
+    class _ParsedURL:
+        scheme = _WeirdString("https")
+        netloc = _WeirdString("example.local")
+        hostname = "example.local"
+        query = _WeirdString("")
+        fragment = _WeirdString("")
+        username = None
+        password = None
+        path = _WeirdString("/api")
+
+        @property
+        def port(self) -> int:
+            return 443
+
+    monkeypatch.setattr(config_module, "urlparse", lambda _value: _ParsedURL())
+
+    with pytest.raises(
+        HyperbrowserError, match="base_url parser returned invalid URL components"
+    ):
+        ClientConfig.normalize_base_url("https://example.local")
+
+
 def test_client_config_normalize_base_url_rejects_invalid_hostname_types(
     monkeypatch: pytest.MonkeyPatch,
 ):