Skip to content

Commit 9aa0e12

Browse files
Tighten default-prefix constant usage guard checks
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 0e38993 commit 9aa0e12

1 file changed

Lines changed: 34 additions & 13 deletions

File tree

tests/test_file_message_default_constant_usage.py

Lines changed: 34 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,44 @@
88
MODULE_EXPECTATIONS = (
99
(
1010
"hyperbrowser/client/managers/extension_create_utils.py",
11-
(
12-
"EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX",
13-
"EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX",
14-
),
11+
{
12+
"EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX": (
13+
"default_prefix=EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX"
14+
),
15+
"EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX": (
16+
"default_prefix=EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX"
17+
),
18+
},
1519
),
1620
(
1721
"hyperbrowser/client/managers/sync_manager/extension.py",
18-
("EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX",),
22+
{
23+
"EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX": (
24+
"default_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX"
25+
),
26+
},
1927
),
2028
(
2129
"hyperbrowser/client/managers/async_manager/extension.py",
22-
("EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX",),
30+
{
31+
"EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX": (
32+
"default_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX"
33+
),
34+
},
2335
),
2436
(
2537
"hyperbrowser/client/managers/session_upload_utils.py",
26-
(
27-
"SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX",
28-
"SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX",
29-
"SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX",
30-
),
38+
{
39+
"SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX": (
40+
"default_prefix=SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX"
41+
),
42+
"SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX": (
43+
"default_prefix=SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX"
44+
),
45+
"SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX": (
46+
"default_prefix=SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX"
47+
),
48+
},
3149
),
3250
)
3351

@@ -42,9 +60,12 @@
4260

4361

4462
def test_file_message_helpers_use_shared_default_prefix_constants():
45-
for module_path, expected_constant_names in MODULE_EXPECTATIONS:
63+
for module_path, expected_default_prefix_constants in MODULE_EXPECTATIONS:
4664
module_text = Path(module_path).read_text(encoding="utf-8")
47-
for constant_name in expected_constant_names:
65+
for constant_name, expected_default_assignment in (
66+
expected_default_prefix_constants.items()
67+
):
4868
assert constant_name in module_text
69+
assert expected_default_assignment in module_text
4970
for forbidden_literal in FORBIDDEN_DEFAULT_PREFIX_LITERALS:
5071
assert forbidden_literal not in module_text

0 commit comments

Comments
 (0)