Harden polling operation-name component coercion

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -61,10 +61,13 @@ def _normalized_exception_text(exc: Exception) -> str:
 
 
 def _coerce_operation_name_component(value: object, *, fallback: str) -> str:
-    if isinstance(value, str):
+    if isinstance(value, str) and type(value) is str:
         return value
     try:
-        return str(value)
+        normalized_value = str(value)
+        if type(normalized_value) is not str:
+            raise TypeError("operation name component must normalize to string")
+        return normalized_value
     except Exception:
         return fallback
 

tests/test_polling.py

@@ -216,6 +216,19 @@ def __str__(self) -> str:
     assert operation_name == "crawl job unknown"
 
 
+def test_build_operation_name_falls_back_for_broken_string_subclass_identifiers():
+    class _BrokenStringIdentifier(str):
+        def __str__(self) -> str:
+            raise RuntimeError("cannot stringify string identifier")
+
+    operation_name = build_operation_name(
+        "crawl job ",
+        _BrokenStringIdentifier("123"),
+    )
+
+    assert operation_name == "crawl job unknown"
+
+
 def test_build_operation_name_falls_back_for_unstringifiable_prefixes():
     class _BadPrefix:
         def __str__(self) -> str:
@@ -229,6 +242,29 @@ def __str__(self) -> str:
     assert operation_name == "identifier"
 
 
+def test_build_operation_name_falls_back_for_broken_string_subclass_prefixes():
+    class _BrokenStringPrefix(str):
+        def __str__(self) -> str:
+            raise RuntimeError("cannot stringify string prefix")
+
+    operation_name = build_operation_name(
+        _BrokenStringPrefix("crawl job "),
+        "identifier",
+    )
+
+    assert operation_name == "identifier"
+
+
+def test_build_fetch_operation_name_falls_back_for_broken_string_subclass_input():
+    class _BrokenOperationName(str):
+        def __str__(self) -> str:
+            raise RuntimeError("cannot stringify fetch operation name")
+
+    operation_name = build_fetch_operation_name(_BrokenOperationName("crawl job"))
+
+    assert operation_name == "Fetching unknown"
+
+
 def test_build_operation_name_sanitizes_control_characters_in_prefix():
     operation_name = build_operation_name(
         "crawl\njob\t ",