Wrap client api_key strip normalization failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/base.py

@@ -38,7 +38,18 @@ def __init__(
                 )
             if not isinstance(resolved_api_key, str):
                 raise HyperbrowserError("api_key must be a string")
-            if not resolved_api_key.strip():
+            try:
+                normalized_resolved_api_key = resolved_api_key.strip()
+                if not isinstance(normalized_resolved_api_key, str):
+                    raise TypeError("normalized api_key must be a string")
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "Failed to normalize api_key",
+                    original_error=exc,
+                ) from exc
+            if not normalized_resolved_api_key:
                 if api_key_from_constructor:
                     raise HyperbrowserError("api_key must not be empty")
                 raise HyperbrowserError(

tests/test_client_api_key.py

@@ -108,3 +108,42 @@ def test_async_client_rejects_control_character_env_api_key(monkeypatch):
         HyperbrowserError, match="api_key must not contain control characters"
     ):
         AsyncHyperbrowser()
+
+
+@pytest.mark.parametrize("client_class", [Hyperbrowser, AsyncHyperbrowser])
+def test_client_wraps_api_key_strip_runtime_errors(client_class):
+    class _BrokenStripApiKey(str):
+        def strip(self, chars=None):  # type: ignore[override]
+            _ = chars
+            raise RuntimeError("api key strip exploded")
+
+    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
+        client_class(api_key=_BrokenStripApiKey("test-key"))
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+@pytest.mark.parametrize("client_class", [Hyperbrowser, AsyncHyperbrowser])
+def test_client_preserves_hyperbrowser_api_key_strip_errors(client_class):
+    class _BrokenStripApiKey(str):
+        def strip(self, chars=None):  # type: ignore[override]
+            _ = chars
+            raise HyperbrowserError("custom strip failure")
+
+    with pytest.raises(HyperbrowserError, match="custom strip failure") as exc_info:
+        client_class(api_key=_BrokenStripApiKey("test-key"))
+
+    assert exc_info.value.original_error is None
+
+
+@pytest.mark.parametrize("client_class", [Hyperbrowser, AsyncHyperbrowser])
+def test_client_wraps_non_string_api_key_strip_results(client_class):
+    class _NonStringStripResultApiKey(str):
+        def strip(self, chars=None):  # type: ignore[override]
+            _ = chars
+            return object()
+
+    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
+        client_class(api_key=_NonStringStripResultApiKey("test-key"))
+
+    assert isinstance(exc_info.value.original_error, TypeError)