Centralize session upload prefixes in operation metadata

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -199,6 +199,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_session_resource_wrapper_internal_reuse.py` (session resource-wrapper internal reuse of shared model raw request helpers),
   - `tests/test_session_route_constants_usage.py` (session manager route-constant usage enforcement),
   - `tests/test_session_upload_helper_usage.py` (session upload-input normalization helper usage enforcement),
+  - `tests/test_session_upload_metadata_usage.py` (session upload-helper shared operation-metadata prefix usage enforcement),
   - `tests/test_start_and_wait_default_constants_usage.py` (shared start-and-wait default-constant usage enforcement),
   - `tests/test_start_job_context_helper_usage.py` (shared started-job context helper usage enforcement),
   - `tests/test_started_job_helper_boundary.py` (centralization boundary enforcement for started-job helper primitives),

hyperbrowser/client/managers/session_operation_metadata.py

@@ -11,6 +11,9 @@ class SessionOperationMetadata:
     video_recording_url_operation_name: str
     downloads_url_operation_name: str
     upload_file_operation_name: str
+    upload_missing_file_message_prefix: str
+    upload_not_file_message_prefix: str
+    upload_open_file_error_prefix: str
     extend_operation_name: str
     update_profile_operation_name: str
 
@@ -24,6 +27,9 @@ class SessionOperationMetadata:
     video_recording_url_operation_name="session video recording url",
     downloads_url_operation_name="session downloads url",
     upload_file_operation_name="session upload file",
+    upload_missing_file_message_prefix="Upload file not found at path",
+    upload_not_file_message_prefix="Upload file path must point to a file",
+    upload_open_file_error_prefix="Failed to open upload file at path",
     extend_operation_name="session extend",
     update_profile_operation_name="session update profile",
 )

hyperbrowser/client/managers/session_upload_utils.py

@@ -12,6 +12,7 @@
     ensure_existing_file_path,
     open_binary_file,
 )
+from .session_operation_metadata import SESSION_OPERATION_METADATA
 
 
 def normalize_upload_file_input(
@@ -31,11 +32,11 @@ def normalize_upload_file_input(
             raw_file_path,
             missing_file_message=build_file_path_error_message(
                 raw_file_path,
-                prefix="Upload file not found at path",
+                prefix=SESSION_OPERATION_METADATA.upload_missing_file_message_prefix,
             ),
             not_file_message=build_file_path_error_message(
                 raw_file_path,
-                prefix="Upload file path must point to a file",
+                prefix=SESSION_OPERATION_METADATA.upload_not_file_message_prefix,
             ),
         )
         return file_path, None
@@ -80,7 +81,7 @@ def open_upload_files_from_input(
             file_path,
             open_error_message=build_open_file_error_message(
                 file_path,
-                prefix="Failed to open upload file at path",
+                prefix=SESSION_OPERATION_METADATA.upload_open_file_error_prefix,
             ),
         ) as opened_file:
             yield {"file": opened_file}

tests/test_architecture_marker_usage.py

@@ -131,6 +131,7 @@
     "tests/test_session_resource_wrapper_internal_reuse.py",
     "tests/test_session_route_constants_usage.py",
     "tests/test_session_upload_helper_usage.py",
+    "tests/test_session_upload_metadata_usage.py",
     "tests/test_start_and_wait_default_constants_usage.py",
     "tests/test_start_job_context_helper_usage.py",
     "tests/test_started_job_helper_boundary.py",

tests/test_session_upload_metadata_usage.py

@@ -0,0 +1,20 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULE_PATH = "hyperbrowser/client/managers/session_upload_utils.py"
+
+
+def test_session_upload_helper_uses_shared_operation_metadata_prefixes():
+    module_text = Path(MODULE_PATH).read_text(encoding="utf-8")
+
+    assert "session_operation_metadata import" in module_text
+    assert "SESSION_OPERATION_METADATA.upload_missing_file_message_prefix" in module_text
+    assert "SESSION_OPERATION_METADATA.upload_not_file_message_prefix" in module_text
+    assert "SESSION_OPERATION_METADATA.upload_open_file_error_prefix" in module_text
+    assert 'prefix="Upload file not found at path"' not in module_text
+    assert 'prefix="Upload file path must point to a file"' not in module_text
+    assert 'prefix="Failed to open upload file at path"' not in module_text