Improve transport error extraction for nested payload fields

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -1,19 +1,35 @@
+import json
 from typing import Any
 
 import httpx
 
 
+def _stringify_error_value(value: Any) -> str:
+    if isinstance(value, str):
+        return value
+    if isinstance(value, dict):
+        for key in ("message", "error", "detail"):
+            nested_value = value.get(key)
+            if nested_value is not None:
+                return _stringify_error_value(nested_value)
+    try:
+        return json.dumps(value, sort_keys=True)
+    except TypeError:
+        return str(value)
+
+
 def extract_error_message(response: httpx.Response, fallback_error: Exception) -> str:
     try:
         error_data: Any = response.json()
     except Exception:
         return response.text or str(fallback_error)
 
     if isinstance(error_data, dict):
-        message = error_data.get("message") or error_data.get("error")
-        if message is not None:
-            return str(message)
+        for key in ("message", "error", "detail"):
+            message = error_data.get(key)
+            if message is not None:
+                return _stringify_error_value(message)
         return response.text or str(fallback_error)
     if isinstance(error_data, str):
         return error_data
-    return str(response.text or str(fallback_error))
+    return _stringify_error_value(response.text or str(fallback_error))

tests/test_transport_response_handling.py

@@ -97,7 +97,7 @@ def test_sync_handle_response_with_non_string_message_field_coerces_to_string():
     try:
         response = _build_response(500, '{"message":{"detail":"failed"}}')
 
-        with pytest.raises(HyperbrowserError, match="detail"):
+        with pytest.raises(HyperbrowserError, match="failed"):
             transport._handle_response(response)
     finally:
         transport.close()
@@ -109,7 +109,32 @@ async def run() -> None:
         try:
             response = _build_response(500, '{"message":{"detail":"failed"}}')
 
-            with pytest.raises(HyperbrowserError, match="detail"):
+            with pytest.raises(HyperbrowserError, match="failed"):
+                await transport._handle_response(response)
+        finally:
+            await transport.close()
+
+    asyncio.run(run())
+
+
+def test_sync_handle_response_with_nested_error_message_uses_nested_value():
+    transport = SyncTransport(api_key="test-key")
+    try:
+        response = _build_response(500, '{"error":{"message":"nested failure"}}')
+
+        with pytest.raises(HyperbrowserError, match="nested failure"):
+            transport._handle_response(response)
+    finally:
+        transport.close()
+
+
+def test_async_handle_response_with_detail_field_uses_detail_value():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            response = _build_response(500, '{"detail":"invalid request"}')
+
+            with pytest.raises(HyperbrowserError, match="invalid request"):
                 await transport._handle_response(response)
         finally:
             await transport.close()