Validate session upload file input shape

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -112,20 +112,21 @@ async def get_downloads_url(self, id: str) -> GetSessionDownloadsUrlResponse:
     async def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
-        response = None
         if isinstance(file_input, (str, PathLike)):
             with open(os.fspath(file_input), "rb") as file_obj:
                 files = {"file": file_obj}
                 response = await self._client.transport.post(
                     self._client._build_url(f"/session/{id}/uploads"),
                     files=files,
                 )
-        else:
+        elif hasattr(file_input, "read"):
             files = {"file": file_input}
             response = await self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),
                 files=files,
             )
+        else:
+            raise TypeError("file_input must be a file path or file-like object")
 
         return UploadFileResponse(**response.data)
 

hyperbrowser/client/managers/sync_manager/session.py

@@ -104,20 +104,21 @@ def get_downloads_url(self, id: str) -> GetSessionDownloadsUrlResponse:
     def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
-        response = None
         if isinstance(file_input, (str, PathLike)):
             with open(os.fspath(file_input), "rb") as file_obj:
                 files = {"file": file_obj}
                 response = self._client.transport.post(
                     self._client._build_url(f"/session/{id}/uploads"),
                     files=files,
                 )
-        else:
+        elif hasattr(file_input, "read"):
             files = {"file": file_input}
             response = self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),
                 files=files,
             )
+        else:
+            raise TypeError("file_input must be a file path or file-like object")
 
         return UploadFileResponse(**response.data)
 

tests/test_session_upload_file.py

@@ -1,5 +1,7 @@
 import asyncio
+import io
 from pathlib import Path
+import pytest
 
 from hyperbrowser.client.managers.async_manager.session import (
     SessionManager as AsyncSessionManager,
@@ -93,3 +95,45 @@ async def run():
     assert (
         transport.received_file is not None and transport.received_file.closed is True
     )
+
+
+def test_sync_session_upload_file_accepts_file_like_object():
+    transport = _SyncTransport()
+    manager = SyncSessionManager(_FakeClient(transport))
+    file_obj = io.BytesIO(b"content")
+
+    response = manager.upload_file("session_123", file_obj)
+
+    assert response.file_name == "file.txt"
+    assert transport.received_file is file_obj
+
+
+def test_async_session_upload_file_accepts_file_like_object():
+    transport = _AsyncTransport()
+    manager = AsyncSessionManager(_FakeClient(transport))
+    file_obj = io.BytesIO(b"content")
+
+    async def run():
+        return await manager.upload_file("session_123", file_obj)
+
+    response = asyncio.run(run())
+
+    assert response.file_name == "file.txt"
+    assert transport.received_file is file_obj
+
+
+def test_sync_session_upload_file_rejects_invalid_input_type():
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+
+    with pytest.raises(TypeError, match="file_input must be a file path"):
+        manager.upload_file("session_123", 123)  # type: ignore[arg-type]
+
+
+def test_async_session_upload_file_rejects_invalid_input_type():
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+
+    async def run():
+        with pytest.raises(TypeError, match="file_input must be a file path"):
+            await manager.upload_file("session_123", 123)  # type: ignore[arg-type]
+
+    asyncio.run(run())