Skip to content

Commit de9deda

Browse files
Make fetch operation-name idempotence case-insensitive
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent ac67c81 commit de9deda

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

hyperbrowser/client/polling.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ def build_operation_name(prefix: object, identifier: object) -> str:
129129

130130
def build_fetch_operation_name(operation_name: object) -> str:
131131
normalized_operation_name = build_operation_name("", operation_name)
132-
if normalized_operation_name.startswith(_FETCH_OPERATION_NAME_PREFIX):
132+
if normalized_operation_name.lower().startswith(
133+
_FETCH_OPERATION_NAME_PREFIX.lower()
134+
):
133135
return normalized_operation_name
134136
return build_operation_name(
135137
_FETCH_OPERATION_NAME_PREFIX,

tests/test_polling.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ def test_build_fetch_operation_name_is_idempotent_for_prefixed_inputs():
5252
assert build_fetch_operation_name(operation_name) == operation_name
5353

5454

55+
def test_build_fetch_operation_name_is_idempotent_case_insensitive():
56+
operation_name = "fEtChInG crawl job 123"
57+
assert build_fetch_operation_name(operation_name) == operation_name
58+
59+
5560
def test_build_fetch_operation_name_truncates_to_preserve_fetch_prefix():
5661
operation_name = "x" * 200
5762
fetch_operation_name = build_fetch_operation_name(operation_name)

0 commit comments

Comments
 (0)