Wrap unexpected file path check runtime errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/file_utils.py

@@ -38,13 +38,21 @@ def ensure_existing_file_path(
         raise HyperbrowserError("file_path must not contain control characters")
     try:
         path_exists = os.path.exists(normalized_path)
-    except (OSError, ValueError) as exc:
+    except HyperbrowserError:
+        raise
+    except (OSError, ValueError, TypeError) as exc:
+        raise HyperbrowserError("file_path is invalid", original_error=exc) from exc
+    except Exception as exc:
         raise HyperbrowserError("file_path is invalid", original_error=exc) from exc
     if not path_exists:
         raise HyperbrowserError(missing_file_message)
     try:
         is_file = os.path.isfile(normalized_path)
-    except (OSError, ValueError) as exc:
+    except HyperbrowserError:
+        raise
+    except (OSError, ValueError, TypeError) as exc:
+        raise HyperbrowserError("file_path is invalid", original_error=exc) from exc
+    except Exception as exc:
         raise HyperbrowserError("file_path is invalid", original_error=exc) from exc
     if not is_file:
         raise HyperbrowserError(not_file_message)

tests/test_file_utils.py

@@ -136,6 +136,45 @@ def raising_exists(path: str) -> bool:
         )
 
 
+def test_ensure_existing_file_path_wraps_unexpected_exists_errors(monkeypatch):
+    def raising_exists(path: str) -> bool:
+        _ = path
+        raise RuntimeError("unexpected exists failure")
+
+    monkeypatch.setattr(file_utils.os.path, "exists", raising_exists)
+
+    with pytest.raises(HyperbrowserError, match="file_path is invalid") as exc_info:
+        ensure_existing_file_path(
+            "/tmp/maybe-invalid",
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is not None
+
+
+def test_ensure_existing_file_path_wraps_unexpected_isfile_errors(
+    monkeypatch, tmp_path: Path
+):
+    file_path = tmp_path / "target.txt"
+    file_path.write_text("content")
+
+    def raising_isfile(path: str) -> bool:
+        _ = path
+        raise RuntimeError("unexpected isfile failure")
+
+    monkeypatch.setattr(file_utils.os.path, "isfile", raising_isfile)
+
+    with pytest.raises(HyperbrowserError, match="file_path is invalid") as exc_info:
+        ensure_existing_file_path(
+            str(file_path),
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is not None
+
+
 def test_ensure_existing_file_path_wraps_fspath_runtime_errors():
     class _BrokenPathLike:
         def __fspath__(self) -> str: