Fix test-framework resolution and hs-Cpp compilation across platforms (#31)

* Fix test-framework resolution and hs-Cpp compilation across platforms

- Remove explicit version from testFramework() — let the plugin resolve
  it automatically from the configured platform dependency
- Extract makeCmakeExecutable() into platform-specific branches:
  252/253 use getBundledCMakeToolBinary(Boolean, ToolKind) API,
  261 uses getBundledCMakeToolBinary(ToolKind) API

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* CI: run specific test tasks to avoid module classpath issues

Module tests (hs-core, hs-Java, etc.) cannot run directly because
prepareSandbox is disabled in modules, leaving IntelliJ Platform
jars off the test runtime classpath. Run :intellij-plugin:test
(which includes hs-core tests) plus standalone module tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove ignoreFailures=true so CI fails on test failures

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: meanmail

.github/workflows/ci.yaml

@@ -42,7 +42,7 @@ jobs:
           echo "VERSION=${BASE_VERSION}.${{ github.run_number }}" >> $GITHUB_ENV
 
       - name: Run tests
-        run: ./gradlew test -PenvironmentName=${{ matrix.environmentName }} -PpluginVersion=${{ env.VERSION }}
+        run: ./gradlew :intellij-plugin:test :hs-edu-format:test :hs-framework-storage:test -PenvironmentName=${{ matrix.environmentName }} -PpluginVersion=${{ env.VERSION }}
 
       - name: Verify plugin
         run: ./gradlew verifyPlugin -PenvironmentName=${{ matrix.environmentName }} -PpluginVersion=${{ env.VERSION }}

buildSrc/src/main/kotlin/common-conventions.gradle.kts

@@ -68,7 +68,6 @@ tasks {
   withType<Test> {
     withProp("excludeTests") { exclude(it) }
 
-    ignoreFailures = true
     filter {
       isFailOnNoMatchingTests = false
     }

buildSrc/src/main/kotlin/intellijUtils.kt

@@ -186,10 +186,10 @@ fun IntelliJPlatformDependenciesExtension.testIntellijPlugins(notations: List<St
 }
 
 fun IntelliJPlatformDependenciesExtension.testIntellijPlatformFramework(
-  project: Project,
+  @Suppress("unused") project: Project,
   frameworkType: TestFrameworkType = TestFrameworkType.Platform,
 ) {
-  testFramework(frameworkType, project.baseVersion.toTypeWithVersion().version)
+  testFramework(frameworkType)
 }
 
 // Since 2024.1 CLion has two sets of incompatible plugins: based on classic language engine and new one (AKA Radler).

intellij-plugin/hs-Cpp/branches/252/src/org/hyperskill/academy/cpp/cmakeCompat.kt

@@ -0,0 +1,12 @@
+package org.hyperskill.academy.cpp
+
+import com.jetbrains.cidr.cpp.toolchains.CMakeExecutableTool
+
+// BACKCOMPAT: 252. In 2025.2 getBundledCMakeToolBinary takes (Boolean, ToolKind) parameters
+internal fun makeCmakeExecutable() {
+  @Suppress("DEPRECATION")
+  val cmakeFile = CMakeExecutableTool.getBundledCMakeToolBinary(false, CMakeExecutableTool.ToolKind.CMAKE)
+  if (cmakeFile.exists() && !cmakeFile.canExecute()) {
+    cmakeFile.setExecutable(true)
+  }
+}

intellij-plugin/hs-Cpp/branches/253/src/org/hyperskill/academy/cpp/cmakeCompat.kt

@@ -0,0 +1,12 @@
+package org.hyperskill.academy.cpp
+
+import com.jetbrains.cidr.cpp.toolchains.CMakeExecutableTool
+
+// BACKCOMPAT: 253. In 2025.3 getBundledCMakeToolBinary takes (Boolean, ToolKind) parameters
+internal fun makeCmakeExecutable() {
+  @Suppress("DEPRECATION")
+  val cmakeFile = CMakeExecutableTool.getBundledCMakeToolBinary(false, CMakeExecutableTool.ToolKind.CMAKE)
+  if (cmakeFile.exists() && !cmakeFile.canExecute()) {
+    cmakeFile.setExecutable(true)
+  }
+}

intellij-plugin/hs-Cpp/branches/261/src/org/hyperskill/academy/cpp/cmakeCompat.kt

@@ -0,0 +1,10 @@
+package org.hyperskill.academy.cpp
+
+import com.jetbrains.cidr.cpp.toolchains.CMakeExecutableTool
+
+internal fun makeCmakeExecutable() {
+  val cmakeFile = CMakeExecutableTool.getBundledCMakeToolBinary(CMakeExecutableTool.ToolKind.CMAKE)
+  if (cmakeFile.exists() && !cmakeFile.canExecute()) {
+    cmakeFile.setExecutable(true)
+  }
+}

intellij-plugin/hs-Cpp/src/org/hyperskill/academy/cpp/CppConstantsPool.kt

@@ -47,13 +47,6 @@ val CMAKE_MINIMUM_REQUIRED_LINE_VALUE: String by lazy {
   }
 }
 
-private fun makeCmakeExecutable() {
-  val cmakeFile = CMakeExecutableTool.getBundledCMakeToolBinary(CMakeExecutableTool.ToolKind.CMAKE)
-  if (cmakeFile.exists() && !cmakeFile.canExecute()) {
-    cmakeFile.setExecutable(true)
-  }
-}
-
 const val CMAKE_PROJECT_NAME_KEY: String = "PROJECT_NAME"
 
 const val CMAKE_CPP_STANDARD_KEY: String = "CPP_STANDARD"