Commit c3fd1de
spillover-tva: fix CI failure — skip notebook-loading guards when source absent
CI's pure-Python and Rust matrix jobs copy `tests/` to an isolated
location (per the "Copy tests to isolated location (Unix)" workflow
step) WITHOUT the `docs/` tree, to verify the installed package
doesn't depend on the source tree. Two of my new drift tests need
to load `docs/tutorials/23_spillover_tva.ipynb` and fail with
`FileNotFoundError: '/private/tmp/docs/tutorials/23_spillover_tva.ipynb'`
on every non-source-tree job.
Failing jobs (from run 26416449494):
- Python Tests (macos-latest, py3.11/3.13/3.14)
- Python Tests (windows-latest, py3.13)
- Python Tests (ubuntu-24.04-arm, py3.14)
Fix: both `test_notebook_dgp_constants_match_test_module_constants`
and `test_notebook_dgp_ast_matches_test_fixture` now `pytest.skip()`
gracefully when the notebook source isn't reachable, with a docstring
note explaining that the sync-guard contract is meaningful in local
dev (where edits happen) and the nbmake CI job separately verifies
the notebook executes end-to-end.
This preserves the codex R4/R6 P2 fixes (notebook source IS available
in local dev runs and in the iterative codex-review workflow, so the
guards still trigger on real edits) while making the suite robust to
the project's isolated-tests CI pattern.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent eda04c0 commit c3fd1de
1 file changed
Lines changed: 30 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
389 | | - | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
390 | 398 | | |
391 | 399 | | |
392 | 400 | | |
393 | 401 | | |
394 | 402 | | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
395 | 410 | | |
396 | 411 | | |
397 | 412 | | |
| |||
453 | 468 | | |
454 | 469 | | |
455 | 470 | | |
456 | | - | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
457 | 478 | | |
458 | 479 | | |
459 | 480 | | |
460 | 481 | | |
461 | 482 | | |
462 | 483 | | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
463 | 491 | | |
464 | 492 | | |
465 | 493 | | |
| |||
0 commit comments