From df1f79f7898d3a62b8764ced5b360a8ff771fd53 Mon Sep 17 00:00:00 2001 From: Zac-Smucker-Bryan Date: Fri, 26 Jun 2026 13:42:20 -0500 Subject: [PATCH 1/2] docs: fix E2E testing guide link in contributing guide Link 404s if viewing from https://github.com/ionic-team/ionic-framework?tab=contributing-ov-file --- docs/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 0a6687d7b3d..e8020a2ad7b 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -293,7 +293,7 @@ npm install file:/~/ionic-vue-router-7.0.1.tgz 3. If a new test is needed, the easiest way is to copy the `basic/` directory from the component's `test/` directory, rename it, and edit the content in both the `index.html` and `e2e.ts` file (see [Screenshot Tests](#screenshot-tests) for more information on this file). 4. The `preview/` directory is used in the documentation as a demo. Only update this test if there is a bug in the test or if the API has a change that hasn't been updated in the test. -See [Ionic's E2E testing guide](../core/src/utils/test/playwright/docs/README.md) for information regarding the tools you can use to test Ionic. +See [Ionic's E2E testing guide](/core/src/utils/test/playwright/docs/README.md) for information regarding the tools you can use to test Ionic. ##### Screenshot Tests From 343fe066e8a92f21e103c3047fc5d59696b66fb9 Mon Sep 17 00:00:00 2001 From: Zac-Smucker-Bryan Date: Fri, 26 Jun 2026 14:16:03 -0500 Subject: [PATCH 2/2] docs: add steps to syncing local changes for Angular testing Add pre-step to use npm unlink * to remove problematic links. Add step to build angular server as part of the steps to sync all changes. Add clarification that playwright install is necessary for first time testing changes. --- docs/angular/testing.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/angular/testing.md b/docs/angular/testing.md index 4e18351378e..419a8b2ee09 100644 --- a/docs/angular/testing.md +++ b/docs/angular/testing.md @@ -6,16 +6,20 @@ Ionic Framework supports multiple versions of Angular. As a result, we need to v The Angular test app supports syncing your locally built changes for validation. This allows you to test local changes like `core` without having to publish a new version of the package. +0. In the root directory, run `npm unlink *` to remove any previous links you have built. 1. Build the `core` directory. 2. Navigate to `packages/angular` and run `npm run sync`. 3. Build `packages/angular` using `npm run build`. -4. [Build the Angular test app](#test-app-build-structure). -5. Navigate to the built test app directory (e.g. `packages/angular/test/build/ng14`). -6. Install dependencies using `npm install`. -7. Sync your local changes using `npm run sync`. +4. Navigate to `packages/angular-server` and run `npm install` and `npm run build`. +5. [Build the Angular test app](#test-app-build-structure) using `./build.sh`. +6. Navigate to the built test app directory (e.g. `packages/angular/test/build/ng14`). +7. Install dependencies using `npm install`. +8. Sync your local changes using `npm run sync`. From here you can either build the application or start a local dev server. When re-syncing changes, you will need to [wipe or disable the application cache](#application-cache). +If this is your first time running Playwright tests in the repository, install the [Playwright browser dependencies](/docs/core/testing/usage-instructions.md#installing-dependencies) + > [!NOTE] > Syncing is required to verify that the minimal supported Angular version is still compatible with the latest Ionic Framework changes. > For example, Ionic Framework 8 supports Angular 16, but the latest version of Ionic Framework may not be compatible with Angular 16. Syncing allows you to verify that the latest changes are still compatible with the minimal supported version.