Bugfix string not printing uint64_t correctly

itzandroidtab · itzandroidtab · commit 09b89b0e503d · 2026-03-15T08:28:52.000+01:00
diff --git a/klib/string.hpp b/klib/string.hpp
@@ -335,7 +335,7 @@ namespace klib::string::detail {
             }
         }
 
-        while (static_cast<uint32_t>(value) > 0) {
+        while (static_cast<std::make_unsigned_t<T>>(value) > 0) {
             chars += 1;
 
             if constexpr (B == base::BIN) {
@@ -471,7 +471,7 @@ namespace klib::string::detail {
         // loop until we dont have any more characters left
         for (uint32_t i = 0; i < count; i++) {
             // get the remainder
-            const T remainder = static_cast<uint32_t>(value) % b;
+            const T remainder = static_cast<std::make_unsigned_t<T>>(value) % b;
 
             // add the letter to the string
             if (remainder > 9) {

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ namespace klib::string::detail {`
`335`	`335`	`}`
`336`	`336`	`}`
`337`	`337`
`338`		`- while (static_cast<uint32_t>(value) > 0) {`
	`338`	`+ while (static_cast<std::make_unsigned_t<T>>(value) > 0) {`
`339`	`339`	`chars += 1;`
`340`	`340`
`341`	`341`	`if constexpr (B == base::BIN) {`
`@@ -471,7 +471,7 @@ namespace klib::string::detail {`
`471`	`471`	`// loop until we dont have any more characters left`
`472`	`472`	`for (uint32_t i = 0; i < count; i++) {`
`473`	`473`	`// get the remainder`
`474`		`- const T remainder = static_cast<uint32_t>(value) % b;`
	`474`	`+ const T remainder = static_cast<std::make_unsigned_t<T>>(value) % b;`
`475`	`475`
`476`	`476`	`// add the letter to the string`
`477`	`477`	`if (remainder > 9) {`