fix: continue cask upgrades after formula failures#32
Open
itzptk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgradeAllinto independent formula and cask phases so cask upgrades still run after a formula-phase failure unless the job is aborted.Verification
npm run test:node -- electron/services/homebrew-service.test.ts -t "runs cask upgrades and reports both phases when formula upgrades fail"failed because only['upgrade', '--formula']was called.npm run test:node -- electron/services/homebrew-service.test.ts -t "runs cask upgrades and reports both phases when formula upgrades fail"→ 1 passed.npm run test:node -- electron/services/homebrew-service.test.ts→ 68 passed.npm run test:node→ 15 files passed, 117 tests passed.npm run test:all→ Angular 114 files / 252 tests passed, Node 15 files / 117 tests passed. Existing dark-mode media-query stderr warnings were emitted but the command exited 0.npm run build→ Angular production build and Electron tsup build succeeded.Closes #31