Skip to content

fix: continue cask upgrades after formula failures#32

Open
itzptk wants to merge 1 commit into
mainfrom
fix/issue-31-upgrade-all-cask-after-formula-failure-20260605103023
Open

fix: continue cask upgrades after formula failures#32
itzptk wants to merge 1 commit into
mainfrom
fix/issue-31-upgrade-all-cask-after-formula-failure-20260605103023

Conversation

@itzptk

@itzptk itzptk commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Split upgradeAll into independent formula and cask phases so cask upgrades still run after a formula-phase failure unless the job is aborted.
  • Collect per-phase success/failure output and emit one final failed job event that names the failed phase while preserving output from both phases.
  • Added regression coverage for formula failure followed by a successful cask upgrade.

Verification

  • RED before fix: npm run test:node -- electron/services/homebrew-service.test.ts -t "runs cask upgrades and reports both phases when formula upgrades fail" failed because only ['upgrade', '--formula'] was called.
  • npm run test:node -- electron/services/homebrew-service.test.ts -t "runs cask upgrades and reports both phases when formula upgrades fail" → 1 passed.
  • npm run test:node -- electron/services/homebrew-service.test.ts → 68 passed.
  • npm run test:node → 15 files passed, 117 tests passed.
  • npm run test:all → Angular 114 files / 252 tests passed, Node 15 files / 117 tests passed. Existing dark-mode media-query stderr warnings were emitted but the command exited 0.
  • npm run build → Angular production build and Electron tsup build succeeded.

Closes #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run cask upgrades even when formula upgrades fail

1 participant