fix: return full maintenance scheduler results#35
Open
itzptk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackgroundSchedulermaintenance methods with the shared IPC contracts they already return.success,output,syncedAt) and cleanup job completion events through the scheduler boundary.Closes #34
Verification
npx tsc --noEmit -p tsconfig.electron.jsonfailed before the fix with the targetelectron/main.ts(452,5)andelectron/main.ts(455,5)TS2322return-type errors, plus the new compile-time regression assertions failed because scheduler methods returned narrowed shapes.ELECTRON_OVERRIDE_DIST_PATH=/tmp npm run test:node -- electron/services/background-scheduler.test.ts→ 8 tests passed.ELECTRON_OVERRIDE_DIST_PATH=/tmp npm run test:node→ 15 files / 117 tests passed.ELECTRON_OVERRIDE_DIST_PATH=/tmp npm run build:electron→ tsup build success.ELECTRON_OVERRIDE_DIST_PATH=/tmp npm run build→ Angular production build and Electron build succeeded.npx tsc --noEmit -p tsconfig.electron.jsonstill exits 2 due pre-existing unrelated Electron type errors, but the targetrunManualMetadataSync/runManualCleanupTS2322errors are absent after the fix; remaining related pre-existing error observed:electron/services/background-scheduler.test.ts(91,5): error TS2349.