Skip to content

fix: preflight template pin targets#40

Open
itzptk wants to merge 1 commit into
mainfrom
fix/action-template-preflight-and-cleanup-20260605195446
Open

fix: preflight template pin targets#40
itzptk wants to merge 1 commit into
mainfrom
fix/action-template-preflight-and-cleanup-20260605195446

Conversation

@itzptk

@itzptk itzptk commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • rejects cask template runs containing pin/unpin steps before registering parent jobs or mutating Homebrew
  • unregisters template parent job metadata in a finally block after success, false-result failures, or thrown step failures
  • expands template runner coverage for cask pin/unpin preflight and parent cleanup paths

Closes #6
Closes #9

Verification

  • npm run test:node -- electron/services/action-template-runner.test.ts
  • npm run test:node
  • npm run build
  • independent code review: passed; follow-up suggestions for cask unpin and thrown-step cleanup coverage were added and reverified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear template parent job metadata after template runs Reject cask template runs before executing pin steps

1 participant