Skip to content

fix: preserve failed batch job ids#45

Open
itzptk wants to merge 1 commit into
mainfrom
fix/issue-5-preserve-failed-batch-job-ids-20260605221304
Open

fix: preserve failed batch job ids#45
itzptk wants to merge 1 commit into
mainfrom
fix/issue-5-preserve-failed-batch-job-ids-20260605221304

Conversation

@itzptk

@itzptk itzptk commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve the failed job event ID in batch item results instead of replacing it with a new UUID
  • route each batch item through a per-item sink that captures failed events while preserving callback binding
  • add regression coverage for failed upgradeMany, uninstallMany, and pinMany items

Verification

  • npm run test:node -- electron/services/homebrew-service.test.ts --testNamePattern "preserves failed item job IDs"
  • npm run test:node -- electron/services/homebrew-service.test.ts
  • npm run test:all
  • npm run build
  • independent pre-commit review passed after fixes

Closes #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve real job IDs for failed batch item results

1 participant