Implemention to clear break (IOCTL_SERIAL_SET_BREAK_OFF)

[marcpuca]

Currently there is no way to invoke clear break if not previously calling sndBreak, please add the feature
required adding ClearCommBreak(hComm) or possibly amending the code to treat duration -1 as an explicit clear

JNIEXPORT jboolean JNICALL Java_jssc_SerialNativeInterface_sendBreak
  (JNIEnv *, jobject, jlong portHandle, jint duration){
	HANDLE hComm = (HANDLE)portHandle;
	// ...
	if(SetCommBreak(hComm) > 0){ // Sets Break ON
		Sleep(duration);
		if(ClearCommBreak(hComm) > 0){ // Sets Break OFF
			returnValue = JNI_TRUE;
		}
	}
	// ...
}

[tresf]

@hiddenalpha any idea? I sort of like the idea of -1 being a magic flag to keep the API simple, but I don't entirely understand the purpose of this well enough to make an educated decision.

[marcpuca]

any progres on this? I have been looking at c# and it appears to be a legitimate call to clear the break

[hiddenalpha]

@hiddenalpha any idea? I sort of like the idea of -1 being a magic flag to keep the API simple, but I don't entirely understand the purpose of this well enough to make an educated decision.

Unfortunately I neither know about SetCommBreak() nor ClearCommBreak(). Further, as these are windows specific calls, I do not know how to write this for the other target platforms.

Edit:

Generally, I could add such code. But I won't be able to do any real world verification, due to me having no use-case for it anywhere. Quick web research indicates there exist similar calls for other host systems.

[marcpuca]

I understand, not sure there is much to test, this would simply allow access to the underlying methods
SetCommBreak(hComm) ClearCommBreak(hComm) thru the same native call.