Skip to content

[JENKINS-45362] Workaround for not detecting changes in externals#191

Closed
r-funke wants to merge 1 commit into
jenkinsci:masterfrom
r-funke:fix-scanpipeline
Closed

[JENKINS-45362] Workaround for not detecting changes in externals#191
r-funke wants to merge 1 commit into
jenkinsci:masterfrom
r-funke:fix-scanpipeline

Conversation

@r-funke

@r-funke r-funke commented Jul 11, 2017

Copy link
Copy Markdown

Like discussed in PR #189 the clean solution would be to extend SCMRevisionImpl to encode the revisions of all externals. But setting isDeterministic() to false is a simple workaround that solves the issue.

@oleg-nenashev

Copy link
Copy Markdown
Member

@jenkinsci/code-reviewers

@daniel-beck

Copy link
Copy Markdown
Member

I'm not sure it's a great idea to add a workaround with a UI option.

@r-funke

r-funke commented Jul 11, 2017

Copy link
Copy Markdown
Author

If #189 gets accepted, what about enabling the workaround whenever additional credentials have been enabled? @jglick commented on this that 1) additional credentials may have been specified but not used, and 2) there may be externals which do not require additional credentials. Regarding 1) I think that this will rarely happen. But if it does, the workaround doesn't seem to break anything. Regarding 2) my experience is that it is always necessary to specify additional credentials when using externals to avoid ISVNAuthentication exception (JENKINS-35227).

@r-funke

r-funke commented Jul 24, 2017

Copy link
Copy Markdown
Author

Any further suggestions?

@jglick jglick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we ever want to have nondeterministic revisions.

@imakowski

Copy link
Copy Markdown

Any news about this?

@theKBro

theKBro commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

this is still an issue....
for each external even if it is from the same svn server we get an error

ERROR: Failed to check repository revision for https://subversion/f_e/external
org.tmatesoft.svn.core.SVNCancelException: svn: E200015: E200015: ISVNAuthentication provider did not provide credentials; HTTP authorization cancelled.
svn: E200015: ISVNAuthentication provider did not provide credentials; HTTP authorization cancelled.

the workaround for this is adding the normal credentials again as additional credentials...
Are there plans to finally fix this?

@r-funke r-funke closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants