Skip to content

JENKINS-5347 Fixed - Added use commit times on files#64

Closed
redsolo wants to merge 3 commits into
jenkinsci:masterfrom
redsolo:master
Closed

JENKINS-5347 Fixed - Added use commit times on files#64
redsolo wants to merge 3 commits into
jenkinsci:masterfrom
redsolo:master

Conversation

@redsolo

@redsolo redsolo commented Feb 1, 2014

Copy link
Copy Markdown

This fixes JENKINS-5347, we have a third party tool that uses the
timestamp on files to notify a cache in the tool to be updated. This fix
will add an option to the Subversion configuration to use commit times.
As the "use-commit-times" is a global configuration but we are only
interested in it as a per-project configuration to not affect our other
builds.

This fixes JENKINS-5347, we have a third party tool that uses the
timestamp on files to notify a cache in the tool to be updated. This fix
will add an option to the Subversion configuration to use commit times.
As the "use-commit-times" is a global configuration but we are only
interested in it as a per-project configuration to not affect our other
builds.
@cloudbees-pull-request-builder

Copy link
Copy Markdown

plugins » subversion-plugin #302 UNSTABLE
Looks like there's a problem with this pull request

Apparently there is some Timezone issues when running the tests on my
and the cloudbees machine. Have reverted the last modified assertion to
a simple long assertion.
@cloudbees-pull-request-builder

Copy link
Copy Markdown

plugins » subversion-plugin #303 UNSTABLE
Looks like there's a problem with this pull request

It seems that the file.lastmodified() is different depending on the OS.
Some OS'es return the exact milliseconds while some doesnt. This fixes
the test so they work both on both type of OSes
@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@cloudbees-pull-request-builder

Copy link
Copy Markdown

plugins » subversion-plugin #304 UNSTABLE
Looks like there's a problem with this pull request

@redsolo

redsolo commented Feb 2, 2014

Copy link
Copy Markdown
Author

Not sure, why the build is unstable. Im getting the same errors when compiling master branch of jenkins-ci/subversion-plugin (without this pull request)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're supposed to add another constructor for backwards compatibility instead of modifying an existing one. (This is why there are so many deprecated ones with fewer arguments)

@recena

recena commented Aug 17, 2015

Copy link
Copy Markdown
Contributor

@redsolo Hello. Do you agree if we close this PR? It seems that there is a PR more recent and based on this. This PR is #116

@redsolo redsolo closed this Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants