Skip to content

Commit f920c70

Browse files
committed
Resolving merge conflicts after merge from upstream for Filter API changes for parseFilterConfig.
1 parent 74b240a commit f920c70

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

xds/src/main/java/io/grpc/xds/Filter.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.common.base.MoreObjects;
2222
import com.google.protobuf.Message;
2323
import io.grpc.ClientInterceptor;
24+
import io.grpc.MetricRecorder;
2425
import io.grpc.ServerInterceptor;
2526
import io.grpc.xds.client.Bootstrapper.BootstrapInfo;
2627
import io.grpc.xds.client.Bootstrapper.ServerInfo;
@@ -91,7 +92,7 @@ default boolean isServerFilter() {
9192
* <li>Filter name+typeUrl in FilterChain's HCM.http_filters.</li>
9293
* </ol>
9394
*/
94-
Filter newInstance(String name);
95+
Filter newInstance(FilterContext context);
9596

9697
/**
9798
* Parses the top-level filter config from raw proto message. The message may be either a {@link
@@ -152,6 +153,18 @@ abstract static class Builder {
152153
}
153154
}
154155

156+
/** Context containing naming and metrics reporting objects for a filter instance. */
157+
@AutoValue
158+
abstract static class FilterContext {
159+
abstract String filterName();
160+
161+
abstract MetricRecorder metricsRecorder();
162+
163+
static FilterContext create(String filterName, MetricRecorder metricsRecorder) {
164+
return new AutoValue_Filter_FilterContext(filterName, metricsRecorder);
165+
}
166+
}
167+
155168
/** Filter config with instance name. */
156169
final class NamedFilterConfig {
157170
// filter instance name

xds/src/test/java/io/grpc/xds/StatefulFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public boolean isServerFilter() {
108108
}
109109

110110
@Override
111-
public synchronized StatefulFilter newInstance(String name) {
111+
public synchronized StatefulFilter newInstance(FilterContext context) {
112112
StatefulFilter filter = new StatefulFilter(counter++);
113113
instances.put(filter.idx, filter);
114114
return filter;

0 commit comments

Comments
 (0)