Fix circuit_breaker_state derived from reachability, not availability#100
Merged
sarroutbi merged 1 commit intoMay 21, 2026
Merged
Conversation
The performance_summary handler derived circuit_breaker_state from verifier_available (URL configured) instead of verifier_reachable (actually responding). When the Verifier was configured but down, the frontend showed "Unreachable" (red) next to "Closed" (green), which is contradictory. Now both fields are consistent: an unreachable Verifier reports circuit_breaker_state as "open". Extract derive_circuit_breaker_state() as a testable pure function and add unit tests covering both branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance_summary handler derived circuit_breaker_state from verifier_available (URL configured) instead of verifier_reachable (actually responding). When the Verifier was configured but down, the frontend showed "Unreachable" (red) next to "Closed" (green), which is contradictory. Now both fields are consistent: an unreachable Verifier reports circuit_breaker_state as "open".
Extract derive_circuit_breaker_state() as a testable pure function and add unit tests covering both branches.