Current Behavior
Standard icons in Sistent (like AddIcon) correctly destructure the fill prop (defaulting to DEFAULT_FILL_NONE which resolves to "currentColor") and apply it directly to their <path> element.
However, the following icons are inconsistent:
1.ExternalLinkIcon (src/icons/ExternalLink/Externallink.tsx):
Does not destructure the fill prop or apply it to its element.
2.DownloadIcon (src/icons/Download/Download.tsx):
Destructures a hardcoded hex color fill = '#455a64' (dark grey) instead of DEFAULT_FILL_NONE and applies it to the tag rather than the element.
This prevents these icons from dynamically inheriting container colors (such as primary white button text), causing them to render in grey.
Expected Behavior
Both icons should:
Destructure fill and default it to DEFAULT_FILL_NONE ("currentColor").
Forward the fill prop to the internal elements so that developers can customize the icon's color dynamically.
Screenshots/Logs
Environment
Contributor Guides and Resources
Current Behavior
Standard icons in Sistent (like
AddIcon) correctly destructure thefillprop (defaulting toDEFAULT_FILL_NONEwhich resolves to"currentColor") and apply it directly to their<path>element.However, the following icons are inconsistent:
1.ExternalLinkIcon (src/icons/ExternalLink/Externallink.tsx):
Does not destructure the fill prop or apply it to its element.
2.DownloadIcon (src/icons/Download/Download.tsx):
Destructures a hardcoded hex color fill = '#455a64' (dark grey) instead of DEFAULT_FILL_NONE and applies it to the tag rather than the element.
This prevents these icons from dynamically inheriting container colors (such as primary white button text), causing them to render in grey.
Expected Behavior
Both icons should:
Destructure fill and default it to DEFAULT_FILL_NONE ("currentColor").
Forward the fill prop to the internal elements so that developers can customize the icon's color dynamically.
Screenshots/Logs
Environment
Contributor Guides and Resources