Skip to content

Update Assessment Editor layout and card structure #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek-Punhani wants to merge 11 commits into
base: unstable
Choose a base branch
from
Open

Update Assessment Editor layout and card structure #5924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7b4d46e
feat(AssessmentEditor): enhance question card display
Abhishek-Punhani May 19, 2026
95e8a66
update border colors to use CSS variables
Abhishek-Punhani May 19, 2026
84f9564
style: add documentation comments for shared and dependent styles in …
Abhishek-Punhani May 20, 2026
dd8686f
refactor(assessment-editor): apply Figma spec style adjustments and a…
Abhishek-Punhani May 21, 2026
18ec00d
refactor: simplify assessment item preview by removing card rendering…
Abhishek-Punhani May 21, 2026
7a61cb1
refactor: remove edit functionality and deprecated props from assessm…
Abhishek-Punhani May 21, 2026
e13ee96
refactor: standardize assessment component padding using CSS custom p…
Abhishek-Punhani May 22, 2026
d99ba11
Migrate AssessmentItemToolbar to KDS
Abhishek-Punhani May 22, 2026
7463b4b
feat: add showTypeLabel prop to AssessmentItemPreview to toggle displ…
Abhishek-Punhani May 22, 2026
294408b
refactor: standardize assessment UI responsiveness and layout across …
Abhishek-Punhani May 23, 2026
34b4f67
refactor: wrap toolbar icons in a container with flex gap styling
Abhishek-Punhani May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...tcuration/contentcuration/frontend/channelEdit/components/AnswersEditor/AnswersEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
v-model="answer.answer"
class="editor"
:mode="isAnswerOpen(answerIdx) ? 'edit' : 'view'"
minHeight="80px"
:imageProcessor="EditorImageProcessor"
@update="updateAnswerText($event, answerIdx)"
@minimize="emitClose"
Expand Down Expand Up @@ -164,6 +165,7 @@
v-model="answer.answer"
class="editor"
:mode="isAnswerOpen(answerIdx) ? 'edit' : 'view'"
minHeight="80px"
:imageProcessor="EditorImageProcessor"
@update="updateAnswerText($event, answerIdx)"
@minimize="emitClose"
Expand Down
42 changes: 19 additions & 23 deletions ...contentcuration/frontend/channelEdit/components/AssessmentEditor/AssessmentEditor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ const clickClose = async assessmentItemWrapper => {
await assessmentItemWrapper.findComponent('[data-test="closeBtn"]').trigger('click');
};

const clickEdit = async assessmentItemWrapper => {
await assessmentItemWrapper
.findComponent(`[data-test="toolbarIcon-${AssessmentItemToolbarActions.EDIT_ITEM}"]`)
.trigger('click');
};

const clickDelete = async assessmentItemWrapper => {
await assessmentItemWrapper
.findComponent(`[data-test="toolbarMenuItem-${AssessmentItemToolbarActions.DELETE_ITEM}"]`)
Comment thread
Abhishek-Punhani marked this conversation as resolved.
Expand Down Expand Up @@ -210,6 +204,15 @@ describe('AssessmentEditor', () => {
expect(wrapper.findComponent('[data-test="showAnswersCheckbox"]').exists()).toBe(true);
});

it("wraps 'Show answers' checkbox in a page container", () => {
expect(wrapper.find('.show-answers-container').exists()).toBe(true);
});

it('renders question card headers', () => {
expect(wrapper.html()).toContain('Question 1 of 4 — Numeric input');
expect(wrapper.html()).toContain('Question 2 of 4 — Single choice');
});

it("doesn't render answers preview by default", () => {
const items = getItems(wrapper);

Expand All @@ -233,32 +236,25 @@ describe('AssessmentEditor', () => {
it('opens an item on item click', async () => {
const items = getItems(wrapper);
await items.at(1).trigger('click');
const updatedItems = getItems(wrapper);
Comment thread
Abhishek-Punhani marked this conversation as resolved.

expect(isItemOpen(items.at(0))).toBe(false);
expect(isItemOpen(items.at(1))).toBe(true);
expect(isItemOpen(items.at(2))).toBe(false);
expect(isItemOpen(items.at(3))).toBe(false);
});

it('opens an item on toolbar edit icon click', async () => {
const items = getItems(wrapper);
await clickEdit(items.at(1));

expect(isItemOpen(items.at(0))).toBe(false);
expect(isItemOpen(items.at(1))).toBe(true);
expect(isItemOpen(items.at(2))).toBe(false);
expect(isItemOpen(items.at(3))).toBe(false);
expect(isItemOpen(updatedItems.at(0))).toBe(false);
expect(isItemOpen(updatedItems.at(1))).toBe(true);
expect(isItemOpen(updatedItems.at(2))).toBe(false);
expect(isItemOpen(updatedItems.at(3))).toBe(false);
});

it('closes an item on close button click', async () => {
// open an item at first
const items = getItems(wrapper);
await items.at(1).trigger('click');
expect(isItemOpen(items.at(1))).toBe(true);
let updatedItems = getItems(wrapper);
expect(isItemOpen(updatedItems.at(1))).toBe(true);

// now close it
await clickClose(items.at(1));
expect(isItemOpen(items.at(1))).toBe(false);
await clickClose(updatedItems.at(1));
updatedItems = getItems(wrapper);
expect(isItemOpen(updatedItems.at(1))).toBe(false);
});

describe('on "Delete" click', () => {
Expand Down
Loading
Loading