Stabilize browser CI races

Author: KSemenenko

.github/workflows/deploy-github-pages.yml

@@ -23,8 +23,8 @@ env:
   UI_TEST_PROJECT: tests/PrompterOne.Web.UITests/PrompterOne.Web.UITests.csproj
 
 jobs:
-  validate_supporting_suites:
-    name: Validate Supporting Suites
+  build_supporting_suites:
+    name: Restore + Build Supporting Suites
     runs-on: ubuntu-latest
     timeout-minutes: 15
 
@@ -40,16 +40,37 @@ jobs:
         with:
           global-json-file: global.json
 
+      - name: Restore solution
+        run: dotnet restore "$SOLUTION_FILE"
+
       - name: Build solution
         run: dotnet build "$SOLUTION_FILE" -warnaserror
 
+  test_supporting_suites:
+    name: Run Supporting Suites
+    needs: build_supporting_suites
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v5
+        with:
+          global-json-file: global.json
+
       - name: Test supporting suites
         run: |
           dotnet test --project "$CORE_TEST_PROJECT"
           dotnet test --project "$APP_TEST_PROJECT"
 
-  validate_browser_suite:
-    name: Validate Browser Suite
+  build_browser_suite:
+    name: Restore + Build Browser Suite
     runs-on: macos-latest
     timeout-minutes: 30
 
@@ -65,9 +86,30 @@ jobs:
         with:
           global-json-file: global.json
 
+      - name: Restore solution
+        run: dotnet restore "$SOLUTION_FILE"
+
       - name: Build solution
         run: dotnet build "$SOLUTION_FILE" -warnaserror
 
+  test_browser_suite:
+    name: Run Browser Suite
+    needs: build_browser_suite
+    runs-on: macos-latest
+    timeout-minutes: 30
+
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v5
+        with:
+          global-json-file: global.json
+
       - name: Install Playwright browser
         run: node "$PLAYWRIGHT_CLI" install chromium
 
@@ -76,8 +118,8 @@ jobs:
   prepare_release:
     name: Resolve Release Version
     needs:
-      - validate_supporting_suites
-      - validate_browser_suite
+      - test_supporting_suites
+      - test_browser_suite
     runs-on: ubuntu-latest
     env:
       APP_PROJECT: src/PrompterOne.Web/PrompterOne.Web.csproj

.github/workflows/pr-validation.yml

@@ -21,8 +21,8 @@ env:
   UI_TEST_PROJECT: tests/PrompterOne.Web.UITests/PrompterOne.Web.UITests.csproj
 
 jobs:
-  build_and_test_supporting:
-    name: Validate Supporting Suites
+  build_supporting_suites:
+    name: Restore + Build Supporting Suites
     runs-on: ubuntu-latest
     timeout-minutes: 15
 
@@ -35,16 +35,34 @@ jobs:
         with:
           global-json-file: global.json
 
+      - name: Restore solution
+        run: dotnet restore "$SOLUTION_FILE"
+
       - name: Build solution
         run: dotnet build "$SOLUTION_FILE" -warnaserror
 
+  test_supporting_suites:
+    name: Run Supporting Suites
+    needs: build_supporting_suites
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v5
+        with:
+          global-json-file: global.json
+
       - name: Test supporting suites
         run: |
           dotnet test --project "$CORE_TEST_PROJECT"
           dotnet test --project "$APP_TEST_PROJECT"
 
-  build_and_test_browser:
-    name: Validate Browser Suite
+  build_browser_suite:
+    name: Restore + Build Browser Suite
     runs-on: macos-latest
     timeout-minutes: 30
 
@@ -57,9 +75,27 @@ jobs:
         with:
           global-json-file: global.json
 
+      - name: Restore solution
+        run: dotnet restore "$SOLUTION_FILE"
+
       - name: Build solution
         run: dotnet build "$SOLUTION_FILE" -warnaserror
 
+  test_browser_suite:
+    name: Run Browser Suite
+    needs: build_browser_suite
+    runs-on: macos-latest
+    timeout-minutes: 30
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v5
+        with:
+          global-json-file: global.json
+
       - name: Install Playwright browser
         run: node "$PLAYWRIGHT_CLI" install chromium
 

AGENTS.md

@@ -133,6 +133,7 @@ Browser test execution rules:
 - Inside that single process, the browser suite may run up to `4` parallel TUnit workers locally; when repeated full-suite CI runs prove resource contention, lower the CI worker cap instead of weakening browser assertions.
 - Do not run `PrompterOne.Web.UITests` in parallel with another `dotnet build` or `dotnet test` command.
 - In GitHub Actions, run the browser suite in its own dedicated macOS job and keep supporting suites in a separate job so CI can parallelize work without Linux x64 browser-runner contention stretching release validation.
+- GitHub Actions pipelines must expose explicit staged jobs with readable names such as restore, build, supporting tests, browser tests, release publish, and deploy; vague single-job `validate` graphs are not acceptable when the user needs to see pipeline phases clearly in the Actions UI.
 - Browser acceptance tests must stay on the production-shaped runtime path; do not add or keep `?wasm-debug=1` or similar debug-query scenarios in automated acceptance coverage unless the user explicitly asks for that path.
 - Do not add Python or ad-hoc runner scripts to bootstrap browser verification. The repo test commands must self-host the app and execute the flows end to end on their own.
 - Browser UI scenarios are the primary acceptance gate for this repo. Component and core tests are supporting layers, not the release bar.

src/PrompterOne.Shared/Editor/Pages/EditorPage.Loading.cs

@@ -63,7 +63,7 @@ private async Task LoadScriptFromQueryAsync(string requestedScriptId)
         }
     }
 
-    private void PopulateEditorState(bool resetHistory = false)
+    private void PopulateEditorState(bool resetHistory = false, bool clearSplitFeedback = true)
     {
         var state = SessionService.State;
         var document = _frontMatterService.Parse(state.Text);
@@ -75,7 +75,10 @@ private void PopulateEditorState(bool resetHistory = false)
         }
 
         ResetMetadataDefaults(state);
-        _splitFeedback = null;
+        if (clearSplitFeedback)
+        {
+            _splitFeedback = null;
+        }
         _sourceText = document.Body;
         ApplyLoadedMetadata(metadata, state);
         _segments = OutlineBuilder.Build(state.ScriptData, document.Body, 0);

src/PrompterOne.Shared/Editor/Pages/EditorPage.Persistence.cs

@@ -100,7 +100,7 @@ private void ApplyPersistedDraftState(long revision)
             return;
         }
 
-        PopulateEditorState();
+        PopulateEditorState(clearSplitFeedback: false);
         _ = InvokeAsync(StateHasChanged);
     }
 

tests/PrompterOne.Web.Tests/Editor/EditorSplitFeedbackInteractionTests.cs

@@ -58,6 +58,46 @@ public void EditorPage_SplitFeedbackStaysVisibleAcrossRedundantSourceChangeEvent
         });
     }
 
+    [Test]
+    public async Task EditorPage_SplitFeedbackStaysVisibleAfterAutosaveRefresh()
+    {
+        var navigationManager = Services.GetRequiredService<NavigationManager>();
+        navigationManager.NavigateTo(AppTestData.Routes.EditorDemo);
+        var cut = Render<EditorPage>();
+
+        cut.WaitForAssertion(() =>
+        {
+            var source = cut.FindByTestId(UiTestIds.Editor.SourceInput);
+            Assert.Contains(AppTestData.Editor.BodyHeading, source.GetAttribute("value"));
+        });
+
+        cut.FindByTestId(UiTestIds.Editor.SourceInput).Input(EditorSplitFeedbackInteractionTestSource.SplitSource);
+        cut.FindByTestId(UiTestIds.Editor.SplitSegment).Click();
+
+        cut.WaitForAssertion(() =>
+        {
+            Assert.Equal(
+                EditorSplitFeedbackInteractionTestSource.SplitActionLabel,
+                cut.FindByTestId(UiTestIds.Editor.SplitResultOpenLibrary).TextContent.Trim());
+        });
+
+        await Task.Delay(EditorSplitFeedbackInteractionTestSource.PostAutosaveObservationDelayMs);
+
+        cut.WaitForAssertion(() =>
+        {
+            Assert.Equal(
+                EditorSplitFeedbackInteractionTestSource.SplitActionLabel,
+                cut.FindByTestId(UiTestIds.Editor.SplitResultOpenLibrary).TextContent.Trim());
+        });
+
+        cut.FindByTestId(UiTestIds.Editor.SplitResultOpenLibrary).Click();
+
+        cut.WaitForAssertion(() =>
+        {
+            Assert.EndsWith(AppRoutes.Library, navigationManager.Uri, StringComparison.Ordinal);
+        });
+    }
+
     [Test]
     public void EditorPage_SplitFeedbackStaysVisibleAfterSourceEdits()
     {
@@ -100,6 +140,7 @@ public void EditorPage_SplitFeedbackStaysVisibleAfterSourceEdits()
 
     private static class EditorSplitFeedbackInteractionTestSource
     {
+        public const int PostAutosaveObservationDelayMs = 1_700;
         public const string EditedSplitSource =
             """
             ## [Episode 1 - How to Think About Systems|140WPM|Professional]

tests/PrompterOne.Web.UITests/Editor/EditorSelectionRenderRegressionTests.cs

@@ -7,16 +7,11 @@ namespace PrompterOne.Web.UITests;
 
 [ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
 [NotInParallel(UiTestParallelization.EditorAuthoringConstraintKey)]
-public sealed class EditorSelectionRenderRegressionTests(StandaloneAppFixture fixture)
+public sealed class EditorSelectionRenderRegressionTests(StandaloneAppFixture fixture) : AppUiTestBase(fixture)
 {
-    private readonly StandaloneAppFixture _fixture = fixture;
-
     [Test]
-    public async Task EditorScreen_SetTextThenSelectStillRendersFloatingBar()
-    {
-        var page = await _fixture.NewPageAsync();
-
-        try
+    public Task EditorScreen_SetTextThenSelectStillRendersFloatingBar() =>
+        RunPageAsync(async page =>
         {
             await page.GotoAsync(BrowserTestConstants.Routes.EditorDemo);
             await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
@@ -27,19 +22,11 @@ public async Task EditorScreen_SetTextThenSelectStillRendersFloatingBar()
 
             await Expect(page.GetByTestId(UiTestIds.Editor.FloatingBar))
                 .ToBeVisibleAsync(new() { Timeout = BrowserTestConstants.Timing.FastVisibleTimeoutMs });
-        }
-        finally
-        {
-            await page.Context.CloseAsync();
-        }
-    }
+        });
 
     [Test]
-    public async Task EditorScreen_BackwardSelection_SelectsExpectedTrailingCharactersFromWordEnd()
-    {
-        var page = await _fixture.NewPageAsync();
-
-        try
+    public Task EditorScreen_BackwardSelection_SelectsExpectedTrailingCharactersFromWordEnd() =>
+        RunPageAsync(async page =>
         {
             await page.GotoAsync(BrowserTestConstants.Routes.EditorDemo);
             await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
@@ -55,19 +42,11 @@ await EditorMonacoDriver.SetBackwardSelectionFromTextEndAsync(
             var selectedText = ReadSelectedText(state);
 
             await Assert.That(selectedText).IsEqualTo(BrowserTestConstants.Editor.ReverseSelectionExpectedText);
-        }
-        finally
-        {
-            await page.Context.CloseAsync();
-        }
-    }
+        });
 
     [Test]
-    public async Task EditorScreen_BackwardSelection_CanExtendAcrossLineBreaks()
-    {
-        var page = await _fixture.NewPageAsync();
-
-        try
+    public Task EditorScreen_BackwardSelection_CanExtendAcrossLineBreaks() =>
+        RunPageAsync(async page =>
         {
             await page.GotoAsync(BrowserTestConstants.Routes.EditorDemo);
             await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
@@ -84,12 +63,7 @@ await EditorMonacoDriver.SetBackwardSelectionFromTextEndAsync(
 
             await Assert.That(selectedText.Length >= BrowserTestConstants.Editor.ReverseMultilineSelectionCharacterCount).IsTrue().Because($"Expected backward selection to keep growing across lines, but only selected {selectedText.Length} characters.");
             await Assert.That(selectedText).Contains(BrowserTestConstants.Editor.LineFeed);
-        }
-        finally
-        {
-            await page.Context.CloseAsync();
-        }
-    }
+        });
 
     private static string ReadSelectedText(EditorMonacoState state)
     {

tests/PrompterOne.Web.UITests/Support/AppUiTestBase.cs

@@ -1,3 +1,4 @@
+using System.Runtime.CompilerServices;
 using Microsoft.Playwright;
 
 namespace PrompterOne.Web.UITests;
@@ -6,24 +7,44 @@ public abstract class AppUiTestBase(StandaloneAppFixture fixture)
 {
     private readonly StandaloneAppFixture _fixture = fixture;
 
-    protected Task RunPageAsync(Func<IPage, Task> scenario) =>
+    protected Task RunPageAsync(
+        Func<IPage, Task> scenario,
+        [CallerMemberName] string testName = "") =>
         RunPageAsync(async page =>
         {
             await scenario(page);
             return true;
-        });
+        }, testName);
 
-    protected async Task<T> RunPageAsync<T>(Func<IPage, Task<T>> scenario)
+    protected async Task<T> RunPageAsync<T>(
+        Func<IPage, Task<T>> scenario,
+        [CallerMemberName] string testName = "")
     {
         var page = await _fixture.NewPageAsync();
 
         try
         {
             return await scenario(page);
         }
+        catch
+        {
+            await TryCaptureFailurePageAsync(page, testName);
+            throw;
+        }
         finally
         {
             await page.Context.CloseAsync();
         }
     }
+
+    private static async Task TryCaptureFailurePageAsync(IPage page, string testName)
+    {
+        try
+        {
+            await UiScenarioArtifacts.CaptureFailurePageAsync(page, testName);
+        }
+        catch
+        {
+        }
+    }
 }