Skip to content

Commit 9d56167

Browse files
KSemenenkoKSemenenko
committed
time out fix
1 parent 3a5704f commit 9d56167

8 files changed

Lines changed: 70 additions & 70 deletions

File tree

‎.github/workflows/pr-validation.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ jobs:
2424
build_supporting_suites:
2525
name: Restore + Build Supporting Suites
2626
runs-on: ubuntu-latest
27-
timeout-minutes: 15
2827

2928
steps:
3029
- name: Checkout
@@ -64,7 +63,6 @@ jobs:
6463
build_browser_suite:
6564
name: Restore + Build Browser Suite
6665
runs-on: macos-latest
67-
timeout-minutes: 30
6866

6967
steps:
7068
- name: Checkout
@@ -85,7 +83,6 @@ jobs:
8583
name: Run Browser Suite
8684
needs: build_browser_suite
8785
runs-on: macos-latest
88-
timeout-minutes: 30
8986

9087
steps:
9188
- name: Checkout

‎AGENTS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ Local `AGENTS.md` files may tighten these values, but they must not loosen them
266266
- Summarize the change, risks, and verification before marking the task complete.
267267
- When the user asks to fix GitHub Actions or CI, do not stop at locally green commands: after pushing, watch the relevant GitHub Actions run and continue iterating until the replacement run is green or an explicit external blocker is documented.
268268
- When the browser suite has already flaked across repeated CI runs, do not keep cycling one-off threshold bumps; prove stability with repeated local browser-suite runs and remove or harden brittle root-cause assertions before calling the fix durable.
269+
- When a concrete failing test is already identified, fix and rerun that failing test and its immediate interference set first; do not sit on a full-suite wait before addressing the known red signal.
269270

270271
### Documentation
271272

‎src/PrompterOne.Shared/Editor/Components/EditorSourcePanel.ToolbarState.cs‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,11 @@ private static string GetFloatingMenuCss(EditorFloatingMenuDescriptor menu) =>
114114
? "efb-dropdown"
115115
: $"efb-dropdown {menu.PanelCssClass}";
116116

117+
private EditorFloatingMenuDescriptor? GetFloatingMenuForAction(EditorToolbarActionDescriptor action) =>
118+
OpenFloatingMenu is { } menu && string.Equals(menu.TriggerTestId, action.TestId, StringComparison.Ordinal)
119+
? menu
120+
: null;
121+
117122
private bool HasOpenToolbarMenu => !string.IsNullOrWhiteSpace(_openMenuId);
118123

119124
private bool ShouldRenderFloatingBar => CanRenderFloatingToolbar && _floatingBarAnchor.HasSelection && !HasOpenToolbarMenu;

‎src/PrompterOne.Shared/Editor/Components/EditorSourcePanel.razor‎

Lines changed: 32 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -135,44 +135,45 @@
135135
var group = FloatingActionGroups[groupIndex];
136136
@foreach (var action in group)
137137
{
138-
<EditorActionButton Action="@action"
139-
ActionSelected="ExecuteToolbarActionAsync"
140-
AriaExpanded="@GetActionAriaExpanded(action)"
141-
Disabled="@GetActionDisabled(action)"
142-
TooltipCssClass="@GetTooltipCssClass(EditorToolbarTooltipPlacement.FloatingToolbar)"
143-
TooltipPlacementValue="@GetTooltipPlacementValue(EditorToolbarTooltipPlacement.FloatingToolbar)" />
138+
<div class="efb-action-slot">
139+
<EditorActionButton Action="@action"
140+
ActionSelected="ExecuteToolbarActionAsync"
141+
AriaExpanded="@GetActionAriaExpanded(action)"
142+
Disabled="@GetActionDisabled(action)"
143+
TooltipCssClass="@GetTooltipCssClass(EditorToolbarTooltipPlacement.FloatingToolbar)"
144+
TooltipPlacementValue="@GetTooltipPlacementValue(EditorToolbarTooltipPlacement.FloatingToolbar)" />
145+
@if (GetFloatingMenuForAction(action) is { } floatingMenu)
146+
{
147+
<div class="@GetFloatingMenuCss(floatingMenu)"
148+
data-test="@floatingMenu.PanelTestId">
149+
@for (var floatingGroupIndex = 0; floatingGroupIndex < floatingMenu.DropdownGroups.Count; floatingGroupIndex++)
150+
{
151+
var dropdownGroup = floatingMenu.DropdownGroups[floatingGroupIndex];
152+
@if (dropdownGroup.HasSeparatorBefore)
153+
{
154+
<div class="efb-drop-sep"></div>
155+
}
156+
<span class="efb-dropdown-label">@dropdownGroup.Label</span>
157+
<div class="efb-menu-list">
158+
@foreach (var dropdownAction in dropdownGroup.Actions)
159+
{
160+
<EditorActionButton Action="@dropdownAction"
161+
ActionSelected="ExecuteToolbarActionAsync"
162+
TooltipCssClass="@GetTooltipCssClass(EditorToolbarTooltipPlacement.FloatingMenu)"
163+
TooltipPlacementValue="@GetTooltipPlacementValue(EditorToolbarTooltipPlacement.FloatingMenu)" />
164+
}
165+
</div>
166+
}
167+
</div>
168+
}
169+
</div>
144170
}
145171

146172
@if (groupIndex < FloatingActionGroups.Count - 1)
147173
{
148174
<span class="efb-sep"></span>
149175
}
150176
}
151-
152-
@if (OpenFloatingMenu is { } floatingMenu)
153-
{
154-
<div class="@GetFloatingMenuCss(floatingMenu)"
155-
data-test="@floatingMenu.PanelTestId">
156-
@for (var groupIndex = 0; groupIndex < floatingMenu.DropdownGroups.Count; groupIndex++)
157-
{
158-
var dropdownGroup = floatingMenu.DropdownGroups[groupIndex];
159-
@if (dropdownGroup.HasSeparatorBefore)
160-
{
161-
<div class="efb-drop-sep"></div>
162-
}
163-
<span class="efb-dropdown-label">@dropdownGroup.Label</span>
164-
<div class="efb-menu-list">
165-
@foreach (var action in dropdownGroup.Actions)
166-
{
167-
<EditorActionButton Action="@action"
168-
ActionSelected="ExecuteToolbarActionAsync"
169-
TooltipCssClass="@GetTooltipCssClass(EditorToolbarTooltipPlacement.FloatingMenu)"
170-
TooltipPlacementValue="@GetTooltipPlacementValue(EditorToolbarTooltipPlacement.FloatingMenu)" />
171-
}
172-
</div>
173-
}
174-
</div>
175-
}
176177
</div>
177178
}
178179
</div>

‎src/PrompterOne.Shared/Editor/Components/EditorSourcePanel.razor.css‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@
136136
.ed-main ::deep .efb-btn--pause:hover{background:rgba(150,209,194,.12);}
137137
.ed-main ::deep .efb-btn--speed:hover{background:rgba(131,197,255,.12);}
138138
.ed-main ::deep .efb-btn--insert:hover{background:rgba(240,197,108,.12);}
139+
.efb-action-slot{position:relative;display:inline-flex;align-items:center;}
139140
.efb-sep{width:1px;height:18px;background:var(--gold-07);margin:0 4px;}
140141
.ed-main ::deep .efb-ai{color:#F4DEA4;font-weight:600;}
141142
.ed-main ::deep .efb-ai:hover{background:var(--gold-12);}

‎tests/PrompterOne.Web.UITests/Editor/EditorAiScrollStabilityTests.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace PrompterOne.Web.UITests;
77

88
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
9+
[NotInParallel(UiTestParallelization.EditorAuthoringConstraintKey)]
910
public sealed class EditorAiScrollStabilityTests(StandaloneAppFixture fixture)
1011
{
1112
private readonly StandaloneAppFixture _fixture = fixture;

‎tests/PrompterOne.Web.UITests/Infrastructure/DynamicHostPortTests.cs‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using Microsoft.Playwright;
12
using PrompterOne.Shared.Contracts;
23
using static Microsoft.Playwright.Assertions;
34

@@ -6,6 +7,7 @@ namespace PrompterOne.Web.UITests;
67
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
78
public sealed class DynamicHostPortTests(StandaloneAppFixture fixture)
89
{
10+
private const int RepeatedBootstrapPageCount = 10;
911
private readonly StandaloneAppFixture _fixture = fixture;
1012

1113
[Test]
@@ -30,4 +32,31 @@ await Expect(page.GetByTestId(UiTestIds.Library.Page))
3032
await page.Context.CloseAsync();
3133
}
3234
}
35+
36+
[Test]
37+
public async Task NewPageAsync_RepeatedBootstrap_DoesNotTripShellDiagnostics()
38+
{
39+
var pages = new List<IPage>(RepeatedBootstrapPageCount);
40+
41+
try
42+
{
43+
for (var pageIndex = 0; pageIndex < RepeatedBootstrapPageCount; pageIndex++)
44+
{
45+
var page = await _fixture.NewPageAsync();
46+
pages.Add(page);
47+
48+
await page.GotoAsync(BrowserTestConstants.Routes.Library);
49+
await Expect(page.GetByTestId(UiTestIds.Library.Page))
50+
.ToBeVisibleAsync(new() { Timeout = BrowserTestConstants.Timing.ExtendedVisibleTimeoutMs });
51+
await Expect(page.GetByTestId(UiTestIds.Diagnostics.Bootstrap)).ToBeHiddenAsync();
52+
}
53+
}
54+
finally
55+
{
56+
foreach (var page in pages)
57+
{
58+
await page.Context.CloseAsync();
59+
}
60+
}
61+
}
3362
}

‎tests/PrompterOne.Web.UITests/Media/synthetic-media-harness.js‎

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
const defaultAudioGain = 0.08;
1313
const debugAudioLevelMultiplier = 2800;
1414
const debugAudioMeterFftSize = 1024;
15-
const pointerDownEventName = "pointerdown";
16-
const keyDownEventName = "keydown";
17-
const touchStartEventName = "touchstart";
1815
const primaryCameraId = "browser-cam-primary";
1916
const secondaryCameraId = "browser-cam-secondary";
2017
const primaryCameraLabel = "Browser Camera A";
@@ -96,11 +93,9 @@
9693
let captureCapabilities = {
9794
supportsConcurrentLocalCameraCaptures: true
9895
};
99-
let audioUnlockInstalled = false;
10096
let lastAudioError = emptyDeviceLabel;
10197
let lastAudioLevelPercent = 0;
10298
let lastAudioMode = emptyDeviceLabel;
103-
let sharedAudioContext = null;
10499
let concealDeviceIdentityUntilMediaRequest =
105100
window.sessionStorage?.getItem(concealIdentitySessionFlag) === "true";
106101
let hasResolvedMediaRequest = false;
@@ -114,36 +109,6 @@
114109
});
115110
}
116111

117-
function installAudioUnlockBridge() {
118-
if (audioUnlockInstalled) {
119-
return;
120-
}
121-
122-
getSharedAudioContext();
123-
audioUnlockInstalled = true;
124-
const unlockAudioContexts = () => {
125-
getSharedAudioContext()?.resume().catch(() => {});
126-
};
127-
128-
[pointerDownEventName, keyDownEventName, touchStartEventName].forEach(eventName => {
129-
window.addEventListener(eventName, unlockAudioContexts, { passive: true });
130-
});
131-
}
132-
133-
function getSharedAudioContext() {
134-
if (!audioContextCtor) {
135-
return null;
136-
}
137-
138-
if (!sharedAudioContext || sharedAudioContext.state === "closed") {
139-
sharedAudioContext = new audioContextCtor({ latencyHint: "interactive" });
140-
}
141-
142-
return sharedAudioContext;
143-
}
144-
145-
installAudioUnlockBridge();
146-
147112
function cloneJson(value) {
148113
return JSON.parse(JSON.stringify(value));
149114
}
@@ -555,7 +520,7 @@
555520
lastAudioError,
556521
lastAudioLevelPercent,
557522
lastAudioMode,
558-
sharedAudioContextState: sharedAudioContext?.state ?? emptyDeviceLabel
523+
sharedAudioContextState: emptyDeviceLabel
559524
};
560525
},
561526
clearRequestLog() {

0 commit comments

Comments
 (0)