Skip to content

Commit a645f61

Browse files
committed
remove timeouts
1 parent 3664f5f commit a645f61

4 files changed

Lines changed: 60 additions & 13 deletions

File tree

.codex/skills/dotnet-codeql/references/workflow.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -276,13 +276,7 @@ strategy:
276276
name: web
277277
```
278278

279-
### Timeout Configuration
280279

281-
```yaml
282-
jobs:
283-
analyze:
284-
timeout-minutes: 60
285-
```
286280

287281
## Security Permissions
288282

.github/workflows/deploy-github-pages.yml

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
build_supporting_suites:
2727
name: Restore + Build Supporting Suites
2828
runs-on: ubuntu-latest
29-
timeout-minutes: 15
3029

3130
permissions:
3231
contents: read
@@ -50,7 +49,6 @@ jobs:
5049
name: Run Supporting Suites
5150
needs: build_supporting_suites
5251
runs-on: ubuntu-latest
53-
timeout-minutes: 15
5452

5553
permissions:
5654
contents: read
@@ -72,7 +70,6 @@ jobs:
7270
build_browser_suite:
7371
name: Restore + Build Browser Suite
7472
runs-on: macos-latest
75-
timeout-minutes: 30
7673

7774
permissions:
7875
contents: read
@@ -96,7 +93,10 @@ jobs:
9693
name: Run Browser Suite
9794
needs: build_browser_suite
9895
runs-on: macos-latest
99-
timeout-minutes: 30
96+
97+
env:
98+
BROWSER_TEST_LOG_DIR: output/test-results/browser-suite
99+
BROWSER_TEST_LOG_PATH: output/test-results/browser-suite/browser-suite.log
100100

101101
permissions:
102102
contents: read
@@ -120,7 +120,31 @@ jobs:
120120
run: node "$PLAYWRIGHT_CLI" install chromium
121121

122122
- name: Test browser suite
123-
run: dotnet test --project "$UI_TEST_PROJECT"
123+
id: browser_tests
124+
shell: bash
125+
run: |
126+
set -o pipefail
127+
mkdir -p "$BROWSER_TEST_LOG_DIR"
128+
dotnet test --project "$UI_TEST_PROJECT" 2>&1 | tee "$BROWSER_TEST_LOG_PATH"
129+
130+
- name: Summarize browser suite
131+
if: always()
132+
shell: bash
133+
env:
134+
BROWSER_TEST_OUTCOME: ${{ steps.browser_tests.outcome }}
135+
run: |
136+
bash ./scripts/ci/write-browser-suite-summary.sh \
137+
"$BROWSER_TEST_LOG_PATH" \
138+
"$BROWSER_TEST_OUTCOME" \
139+
"Run Browser Suite" >> "$GITHUB_STEP_SUMMARY"
140+
141+
- name: Upload browser test logs
142+
if: always()
143+
uses: actions/upload-artifact@v7
144+
with:
145+
name: browser-test-logs-release-pipeline
146+
path: ${{ env.BROWSER_TEST_LOG_DIR }}
147+
if-no-files-found: ignore
124148

125149
- name: Upload Playwright artifacts
126150
if: always()

.github/workflows/pr-validation.yml

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ jobs:
4444
name: Run Supporting Suites
4545
needs: build_supporting_suites
4646
runs-on: ubuntu-latest
47-
timeout-minutes: 15
4847

4948
steps:
5049
- name: Checkout
@@ -84,6 +83,10 @@ jobs:
8483
needs: build_browser_suite
8584
runs-on: macos-latest
8685

86+
env:
87+
BROWSER_TEST_LOG_DIR: output/test-results/browser-suite
88+
BROWSER_TEST_LOG_PATH: output/test-results/browser-suite/browser-suite.log
89+
8790
steps:
8891
- name: Checkout
8992
uses: actions/checkout@v6
@@ -103,7 +106,31 @@ jobs:
103106
run: node "$PLAYWRIGHT_CLI" install chromium
104107

105108
- name: Test browser suite
106-
run: dotnet test --project "$UI_TEST_PROJECT" --verbosity normal
109+
id: browser_tests
110+
shell: bash
111+
run: |
112+
set -o pipefail
113+
mkdir -p "$BROWSER_TEST_LOG_DIR"
114+
dotnet test --project "$UI_TEST_PROJECT" --verbosity normal 2>&1 | tee "$BROWSER_TEST_LOG_PATH"
115+
116+
- name: Summarize browser suite
117+
if: always()
118+
shell: bash
119+
env:
120+
BROWSER_TEST_OUTCOME: ${{ steps.browser_tests.outcome }}
121+
run: |
122+
bash ./scripts/ci/write-browser-suite-summary.sh \
123+
"$BROWSER_TEST_LOG_PATH" \
124+
"$BROWSER_TEST_OUTCOME" \
125+
"Run Browser Suite" >> "$GITHUB_STEP_SUMMARY"
126+
127+
- name: Upload browser test logs
128+
if: always()
129+
uses: actions/upload-artifact@v7
130+
with:
131+
name: browser-test-logs-pr-validation
132+
path: ${{ env.BROWSER_TEST_LOG_DIR }}
133+
if-no-files-found: ignore
107134

108135
- name: Upload Playwright artifacts
109136
if: always()

AGENTS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ Rule format:
102102
- Editor footer status metrics must keep a stable one-row layout while cursor or count values change; line, column, word, and duration updates must not make neighboring status chips jump or reflow.
103103
- Editor footer status chrome should read like a quiet IDE status strip: one compact row, low emphasis, and no oversized chip or outlined-block treatment for static metrics.
104104
- Editor top-toolbar search must remain visible in narrow layouts; when width runs out, the other toolbar groups should become explicitly horizontally scrollable/reachable before search is allowed to disappear.
105+
- Do not push branches or `main` without an explicit user command for that push; local commits are allowed, but network publish actions require clear approval in the current conversation.
106+
- When a CI test job fails, times out, or is cancelled, the workflow summary must still state which tests failed or that the run ended before per-test failure data was available; do not leave browser-suite failures represented only by generic job annotations.
105107
- Public web hosting is split by role: the standalone PrompterOne app in this repo must publish on `app.prompter.one`, while the marketing landing site for `prompter.one` lives in the separate `PrompterOne-LandingPage` repository.
106108
- For deploy-only, domain, CI, or static-site hosting tasks, do not spend time on unrelated app/browser test suites unless the user explicitly asks or the runtime behavior itself changes; prefer workflow, build, and publish-config validation only.
107109
- Repo-wide .NET SDK and test-runner selection belong in the root `global.json`; do not split `global.json` test-runner opt-ins per project or subfolder once the user asks for a global test-platform policy.

0 commit comments

Comments
 (0)