Stabilize browser CI timing probes

KSemenenko · KSemenenko · commit f8caff9758f1 · 2026-04-13T22:56:10.000+02:00
diff --git a/tests/PrompterOne.Web.UITests.Editor/Editor/EditorInteractionTests.cs b/tests/PrompterOne.Web.UITests.Editor/Editor/EditorInteractionTests.cs
@@ -288,7 +288,10 @@ public async Task EditorScreen_DoesNotRenderLegacyStructureInspectorPanel()
 
         try
         {
-            await EditorIsolatedDraftDriver.CreateSeededDraftAsync(page, BrowserTestConstants.Scripts.QuantumId);
+            await EditorIsolatedDraftDriver.CreateSeededDraftAsync(
+                page,
+                BrowserTestConstants.Scripts.QuantumId,
+                waitForPersistedRoute: false);
             await Expect(page.GetByTestId(UiTestIds.Editor.ActiveSegmentName)).ToHaveCountAsync(0);
             await Expect(page.GetByTestId(UiTestIds.Editor.ActiveBlockName)).ToHaveCountAsync(0);
             await Expect(page.GetByTestId(UiTestIds.Editor.SegmentNavigation(0))).ToContainTextAsync("Introduction");
diff --git a/tests/PrompterOne.Web.UITests.Editor/Editor/EditorTypingTests.cs b/tests/PrompterOne.Web.UITests.Editor/Editor/EditorTypingTests.cs
@@ -158,7 +158,7 @@ public async Task EditorScreen_NewDraftDoesNotReplaceRouteWhileTypingIsStillSett
             await page.Keyboard.TypeAsync(BrowserTestConstants.Editor.SecondProbeCharacter);
             await Expect(EditorMonacoDriver.SourceInput(page)).ToHaveValueAsync(BrowserTestConstants.Editor.NewDraftProbeText);
 
-            await page.WaitForTimeoutAsync(BrowserTestConstants.Timing.NewDraftPersistSettleDelayMs);
+            await EditorIsolatedDraftDriver.WaitForAssignedScriptRouteAsync(page);
 
             var currentUri = new Uri(page.Url);
             await Assert.That(currentUri.AbsolutePath).IsEqualTo(BrowserTestConstants.Routes.Editor);
diff --git a/tests/PrompterOne.Web.UITests.Reader/Reader/ReaderPlaybackTimingTests.cs b/tests/PrompterOne.Web.UITests.Reader/Reader/ReaderPlaybackTimingTests.cs
@@ -52,7 +52,7 @@ await Expect(playToggle)
             await Assert.That(samples.Select(sample => sample.EffectiveWpm).ToArray()).IsEquivalentTo(TeleprompterEffectiveWpmSequence, CollectionOrdering.Matching);
 
             var timingTolerance = BrowserTestConstants.ReaderTiming.TeleprompterTimingToleranceMs
-                                  + BrowserTestConstants.ReaderTiming.CapturePollIntervalMs;
+                                  + BrowserTestConstants.ReaderTiming.CapturePollIntervalMs * 2;
 
             for (var sampleIndex = 1; sampleIndex < samples.Length; sampleIndex++)
             {
diff --git a/tests/PrompterOne.Web.UITests.Reader/Teleprompter/TeleprompterAlignmentTooltipFlowTests.cs b/tests/PrompterOne.Web.UITests.Reader/Teleprompter/TeleprompterAlignmentTooltipFlowTests.cs
@@ -12,6 +12,7 @@ public sealed class TeleprompterAlignmentTooltipFlowTests(StandaloneAppFixture f
     private const string LeftRailTooltipStep = "01-left-rail-tooltip";
     private const string RightRailTooltipScenario = "teleprompter-alignment-tooltips-right";
     private const string RightRailTooltipStep = "02-right-rail-tooltip";
+    private const int RevealProbeSchedulerSlackPolls = 4;
 
     private readonly record struct ElementBounds(double Left, double Top, double Right, double Bottom);
 
@@ -33,9 +34,7 @@ await StartTooltipRevealDelayProbeAsync(
                 UiTestIds.Teleprompter.RailTooltip(UiTestIds.Teleprompter.AlignmentTooltipJustifyKey));
             await trigger.HoverAsync();
             var revealDelayMs = await ReadTooltipRevealDelayAsync(page);
-            await Assert.That(revealDelayMs).IsBetween(
-                BrowserTestConstants.TeleprompterFlow.TooltipEarlyCheckDelayMs - BrowserTestConstants.Timing.DiagnosticPollDelayMs,
-                BrowserTestConstants.TeleprompterFlow.TooltipSettleDelayMs + BrowserTestConstants.TeleprompterFlow.TooltipRevealTimingSlackMs);
+            await AssertTooltipRevealDelayWithinBudgetAsync(revealDelayMs);
             await Expect(tooltip).ToBeVisibleAsync();
             await Expect(tooltip).ToHaveTextAsync(BrowserTestConstants.TeleprompterFlow.AlignmentJustifyTooltipText);
 
@@ -68,9 +67,7 @@ await StartTooltipRevealDelayProbeAsync(
                 UiTestIds.Teleprompter.RailTooltip(UiTestIds.Teleprompter.AlignmentTooltipWidthKey));
             await trigger.HoverAsync();
             var revealDelayMs = await ReadTooltipRevealDelayAsync(page);
-            await Assert.That(revealDelayMs).IsBetween(
-                BrowserTestConstants.TeleprompterFlow.TooltipEarlyCheckDelayMs - BrowserTestConstants.Timing.DiagnosticPollDelayMs,
-                BrowserTestConstants.TeleprompterFlow.TooltipSettleDelayMs + BrowserTestConstants.TeleprompterFlow.TooltipRevealTimingSlackMs);
+            await AssertTooltipRevealDelayWithinBudgetAsync(revealDelayMs);
             await Expect(tooltip).ToBeVisibleAsync();
             await Expect(tooltip).ToHaveTextAsync(BrowserTestConstants.TeleprompterFlow.WidthSliderTooltipText);
 
@@ -92,6 +89,13 @@ private static double CalculateIntersectionArea(ElementBounds left, ElementBound
         return overlapWidth * overlapHeight;
     }
 
+    private static async Task AssertTooltipRevealDelayWithinBudgetAsync(int revealDelayMs) =>
+        await Assert.That(revealDelayMs).IsBetween(
+            BrowserTestConstants.TeleprompterFlow.TooltipEarlyCheckDelayMs - BrowserTestConstants.Timing.DiagnosticPollDelayMs,
+            BrowserTestConstants.TeleprompterFlow.TooltipSettleDelayMs
+            + BrowserTestConstants.TeleprompterFlow.TooltipRevealTimingSlackMs
+            + BrowserTestConstants.Timing.DiagnosticPollDelayMs * RevealProbeSchedulerSlackPolls);
+
     private static async Task OpenTeleprompterAsync(IPage page)
     {
         await ReaderRouteDriver.OpenTeleprompterAsync(page, BrowserTestConstants.Routes.TeleprompterDemo);
diff --git a/tests/PrompterOne.Web.UITests/Media/recording-file-harness.js b/tests/PrompterOne.Web.UITests/Media/recording-file-harness.js
@@ -8,6 +8,7 @@
     const minimumVisiblePixelCount = 16;
     const visibleVideoProbeTimeoutMs = 1500;
     const visibleVideoPollDelayMs = 100;
+    const visibleVideoSeekSamples = Object.freeze([0, 0.2, 0.45, 0.7, 0.92]);
     const readyStateHaveCurrentData = 2;
     const runtimeGlobalName = "__prompterOneRuntime";
     const mediaContractProperty = "media";
@@ -193,6 +194,60 @@
         });
     }
 
+    async function seekToVideoSample(videoElement, timeSeconds) {
+        await new Promise(resolve => {
+            let completed = false;
+
+            const finish = () => {
+                if (completed) {
+                    return;
+                }
+
+                completed = true;
+                videoElement.removeEventListener("seeked", finish);
+                resolve();
+            };
+
+            window.setTimeout(finish, visibleVideoPollDelayMs * 4);
+            videoElement.addEventListener("seeked", finish, { once: true });
+
+            try {
+                videoElement.currentTime = timeSeconds;
+            }
+            catch {
+                finish();
+            }
+        });
+    }
+
+    async function detectVisibleVideoAcrossSeekSamples(videoElement, highestVisiblePixelCount) {
+        const duration = Number.isFinite(videoElement.duration)
+            ? videoElement.duration
+            : 0;
+        if (duration <= 0) {
+            return {
+                hasVisibleVideo: highestVisiblePixelCount >= minimumVisiblePixelCount,
+                nonBlackPixelCount: highestVisiblePixelCount
+            };
+        }
+
+        const maximumSeekTime = Math.max(0, duration - 0.01);
+        for (const sample of visibleVideoSeekSamples) {
+            await seekToVideoSample(videoElement, Math.min(maximumSeekTime, duration * sample));
+
+            const frame = detectVisibleVideo(videoElement);
+            highestVisiblePixelCount = Math.max(highestVisiblePixelCount, frame.nonBlackPixelCount);
+            if (frame.hasVisibleVideo) {
+                return frame;
+            }
+        }
+
+        return {
+            hasVisibleVideo: highestVisiblePixelCount >= minimumVisiblePixelCount,
+            nonBlackPixelCount: highestVisiblePixelCount
+        };
+    }
+
     async function detectVisibleVideoAcrossFrames(videoElement) {
         const deadline = Date.now() + visibleVideoProbeTimeoutMs;
         let highestVisiblePixelCount = 0;
@@ -208,10 +263,7 @@
             await waitForNextVideoFrame(videoElement);
         }
 
-        return {
-            hasVisibleVideo: highestVisiblePixelCount >= minimumVisiblePixelCount,
-            nonBlackPixelCount: highestVisiblePixelCount
-        };
+        return await detectVisibleVideoAcrossSeekSamples(videoElement, highestVisiblePixelCount);
     }
 
     async function analyzeSavedRecording() {
@@ -223,6 +275,7 @@
         const videoElement = document.createElement("video");
         videoElement.muted = true;
         videoElement.playsInline = true;
+        videoElement.loop = true;
         videoElement.src = objectUrl;
 
         try {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ await Expect(playToggle)`
`52`	`52`	`await Assert.That(samples.Select(sample => sample.EffectiveWpm).ToArray()).IsEquivalentTo(TeleprompterEffectiveWpmSequence, CollectionOrdering.Matching);`
`53`	`53`
`54`	`54`	`var timingTolerance = BrowserTestConstants.ReaderTiming.TeleprompterTimingToleranceMs`
`55`		`- + BrowserTestConstants.ReaderTiming.CapturePollIntervalMs;`
	`55`	`+ + BrowserTestConstants.ReaderTiming.CapturePollIntervalMs * 2;`
`56`	`56`
`57`	`57`	`for (var sampleIndex = 1; sampleIndex < samples.Length; sampleIndex++)`
`58`	`58`	`{`