#243: Code review adaptions

Author: thunderhook

src/main/java/org/mapstruct/intellij/util/MapstructUtil.java

@@ -682,7 +682,7 @@ public static boolean isMapWithStringKeyType(@Nullable PsiType type) {
         }
 
         PsiType[] parameters = ct.getParameters();
-        if ( parameters.length == 0 ) {
+        if ( parameters.length != 2 ) {
             return false;
         }
 

src/test/java/org/mapstruct/intellij/bugs/_243/DisableSourcePropertyInspectionOnMapTest.java

@@ -25,7 +25,11 @@ protected Class<MapstructReferenceInspection> getInspection() {
         return MapstructReferenceInspection.class;
     }
 
-    public void testDisableSourcePropertyInspectionOnMapTest() {
+    public void testDisableSourcePropertyInspectionOnMap() {
+        doTest();
+    }
+
+    public void testDisableSourcePropertyInspectionOnMapErroneous() {
         doTest();
     }
 }

…leSourcePropertyInspectionOnMapTest.java …isableSourcePropertyInspectionOnMap.javatestData/bugs/_243/DisableSourcePropertyInspectionOnMapTest.java renamed to testData/bugs/_243/DisableSourcePropertyInspectionOnMap.java testData/bugs/_243/DisableSourcePropertyInspectionOnMapTest.java renamed to testData/bugs/_243/DisableSourcePropertyInspectionOnMap.java

@@ -24,22 +24,6 @@ abstract class Issue243Mapper {
     @Mapping(source = "exDate", target = "exDate")
     public abstract CorporateAction mapWithObjectValueMap(Map<String, Object> rowValues);
 
-    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
-    public abstract CorporateAction mapWithIntegerKeyMap(Map<Integer, String> rowValues);
-
-    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
-    public abstract void updateWithIntegerKeyMap(
-        Map<Integer, String> rowValues,
-        @MappingTarget CorporateAction target
-    );
-
-    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
-    @Mapping(source = "payDate", target = "payDate")
-    public abstract CorporateAction mapWithMultipleSources(
-        Map<String, String> rowValues,
-        LocalDate payDate
-    );
-
     @Mapping(source = "rowValues.exDate", target = "exDate")
     @Mapping(source = "payDate", target = "payDate")
     public abstract CorporateAction mapWithMultipleSourcesAndMapName(

testData/bugs/_243/DisableSourcePropertyInspectionOnMapErroneous.java

@@ -0,0 +1,37 @@
+/*
+ * Copyright MapStruct Authors.
+ *
+ * Licensed under the Apache License version 2.0, available at https://www.apache.org/licenses/LICENSE-2.0
+ */
+
+import java.time.LocalDate;
+import java.util.Map;
+
+import org.mapstruct.Mapper;
+import org.mapstruct.Mapping;
+import org.mapstruct.MappingTarget;
+
+@Mapper
+abstract class Issue243ErroneousMapper {
+
+    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
+    public abstract CorporateAction mapWithIntegerKeyMap(Map<Integer, String> rowValues);
+
+    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
+    public abstract void updateWithIntegerKeyMap(
+        Map<Integer, String> rowValues,
+        @MappingTarget CorporateAction target
+    );
+
+    @Mapping(source = "<error descr="Unknown property 'exDate'">exDate</error>", target = "exDate")
+    @Mapping(source = "payDate", target = "payDate")
+    public abstract CorporateAction mapWithMultipleSources(
+        Map<String, String> rowValues,
+        LocalDate payDate
+    );
+}
+
+class CorporateAction {
+    public LocalDate exDate;
+    public LocalDate payDate;
+}