Commit 6d36a81
committed
fix: CI toolchain tests actually use correct toolchain + assertions
Review findings addressed:
1. Linux musl/LLVM steps were NOT actually using those toolchains
(mcpp.toml [toolchain].default overrides global default).
Fix:
- musl: use `mcpp build --target x86_64-linux-musl`
- LLVM: sed-override mcpp.toml before build
- All steps: grep assertion on "Resolved <toolchain>" output
2. Windows: remove `|| true` on critical config/default commands
that silently swallowed failures.
3. Windows: add explicit `mcpp new hello → mcpp run` smoke test
(covers first-run user path that E2E skips due to missing
fresh-sandbox capability).
4. All toolchain build steps: assert via grep that the expected
toolchain was actually resolved.1 parent e5c0968 commit 6d36a81
2 files changed
Lines changed: 21 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | | - | |
| 99 | + | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
103 | 113 | | |
104 | 114 | | |
105 | 115 | | |
| |||
108 | 118 | | |
109 | 119 | | |
110 | 120 | | |
111 | | - | |
112 | | - | |
| 121 | + | |
113 | 122 | | |
114 | 123 | | |
115 | 124 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | 139 | | |
141 | | - | |
| 140 | + | |
142 | 141 | | |
143 | 142 | | |
144 | | - | |
| 143 | + | |
145 | 144 | | |
146 | | - | |
147 | | - | |
148 | 145 | | |
149 | | - | |
| 146 | + | |
150 | 147 | | |
151 | 148 | | |
152 | 149 | | |
153 | 150 | | |
154 | | - | |
| 151 | + | |
| 152 | + | |
155 | 153 | | |
156 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
0 commit comments