upgrade-tests: verify hook binary versions after upgrade+remount#1982
Open
tyrielv wants to merge 1 commit into
Open
upgrade-tests: verify hook binary versions after upgrade+remount#1982tyrielv wants to merge 1 commit into
tyrielv wants to merge 1 commit into
Conversation
tyrielv
force-pushed
the
tyrielv/test-hook-version-upgrade
branch
from
567cb33 to
d5746b5
Compare
tyrielv
force-pushed
the
tyrielv/test-hook-version-upgrade
branch
from
d5746b5 to
dcc5340
Compare
…mount TryUpdateHooks (called at mount time) updated the 3 native hooks (read-object, virtual-filesystem, post-index-change) but skipped the pre-command.exe and post-command.exe copies of GitHooksLoader.exe. Those were only deployed at clone time via InstallHooks, so upgrading GVFS and remounting left stale loader binaries in the enlistment. Refactor TryUpdateHook into an overload that takes explicit source and target paths, then call it from TryUpdateHooks for both command hook loaders using GitHooksLoader.exe as the source. The HookData overload becomes a thin wrapper that delegates to the new one. Add Assert-HookVersionsMatch to the staging-upgrade and clean-upgrade test scenarios: after upgrade completes, remount and verify all 5 hook binaries match the installed versions. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/test-hook-version-upgrade
branch
from
dcc5340 to
c3808d2
Compare
ShiningMassXAcc
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryUpdateHooks (mount time) updates native hooks but not pre-command.exe/post-command.exe loader copies. Those are only deployed at clone time.
This PR adds Assert-HookVersionsMatch to the staging-upgrade and clean-upgrade test scenarios. After upgrade completes, remount the enlistment and verify all 5 hook binaries match the installed versions:
Expected: The pre-command/post-command assertions will fail until TryUpdateHooks is fixed to also update the loader copies.