[release-branch.go1.26] - update openssl backend to point to new location#2291
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft Go 1.26 release-branch patch set and documentation to point the Linux OpenSSL crypto backend at its new repository/module location (github.com/microsoft/go-crypto-openssl) instead of golang-fips/openssl/v2.
Changes:
- Update patch files to use the new
go-crypto-opensslimport paths and vendor paths. - Update FIPS docs to reference
go-crypto-opensslas the OpenSSL backend. - Update the internal
eng/_util/cmd/upgraderdependency metadata to fetch/update the new OpenSSL backend repository.
Show a summary per file
| File | Description |
|---|---|
| patches/0004-Use-crypto-backends.patch | Updates vendored package paths and a test-script comment to reference go-crypto-openssl. |
| patches/0003-Implement-crypto-internal-backend.patch | Repoints OpenSSL backend imports to go-crypto-openssl and adjusts OpenSSL init-time FIPS checks/error reporting. |
| eng/doc/fips/UserGuide.md | Updates backend references/links to the new OpenSSL backend repo and includes macOS backend reference. |
| eng/doc/fips/README.md | Updates OpenSSL backend documentation references/links to the new location. |
| eng/_util/cmd/upgrader/main.go | Updates the upgrader’s OpenSSL dependency metadata to the new repo/module/ref. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/6 changed files
- Comments generated: 2
qmuntal
approved these changes
May 21, 2026
ef84827 to
d5e5447
Compare
d5e5447 to
38d1494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.