You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(skill): document why each git-log path is watched
Replace the stale reference to the upstream "client side changes" workflow
with an inline explanation of what each watched path can affect on the
Java side, so the rolling instructions stand on their own.
Copy file name to clipboardExpand all lines: .claude/skills/playwright-roll/SKILL.md
+6-2Lines changed: 6 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,9 +11,13 @@ Afterwards, walk through the upstream changes that affect the Java client and po
11
11
12
12
## Determining what to port
13
13
14
-
Don't rely on the "Backport client side changes" issue (microsoft/playwright-java#xxxx). The workflow that maintains it is being phased out and the issue is incomplete/stale.
14
+
List the upstream commits that touched a client-relevant path since the last release. The paths cover everything that can change the public Java surface or the wire protocol:
15
15
16
-
Instead, list the upstream commits that touched a client-relevant path since the last release. The triggering paths come from `~/playwright/.github/workflows/pr_check_client_side_changes.yml`:
16
+
-`docs/src/api/` — the source of truth for `api.json`. Method/option additions, removals, and `langs:` filter changes flow from here.
17
+
-`packages/playwright-core/src/client/` — the JS client implementation that the Java client mirrors.
18
+
-`packages/isomorphic/` — selector engines, locator generation/parsing, and aria-snapshot logic shared between client and server. Changes here can affect client-side helpers like `getByRoleSelector`.
19
+
-`packages/playwright/src/matchers/matchers.ts` — assertion-method definitions. Changes here usually correspond to new options on `LocatorAssertions` / `PageAssertions`.
20
+
-`packages/protocol/src/protocol.yml` — the wire protocol schema. Method/event additions, parameter renames, and result-shape changes affect what the Java `*Impl` classes need to send/receive.
0 commit comments