address review feedback: merge path/Path doc types, drop redundant tests

Author: Skn0tt

scripts/documentation_provider.py

@@ -474,13 +474,11 @@ def inner_serialize_doc_type(self, type: Any, direction: str) -> str:
             return f"Union[{', '.join(ll)}]"
 
         type_name = type["name"]
-        if type_name == "path":
+        if type_name in ("path", "Path"):
             if direction == "in":
                 return "Union[pathlib.Path, str]"
             else:
                 return "pathlib.Path"
-        if type_name == "Path":
-            return "pathlib.Path"
 
         if type_name == "function" and "args" not in type:
             return "Callable"

tests/async/test_locators.py

@@ -1294,21 +1294,6 @@ async def test_drop_should_drop_files_and_data_together(page: Page) -> None:
     assert info["data"]["text/plain"] == "label"
 
 
-async def test_highlight_should_attach_a_glass_pane(page: Page) -> None:
-    # Ported from upstream tests/page/locator-highlight.spec.ts. The Python
-    # SDK uses a closed shadow root for the highlight overlay, so we can only
-    # observe the host element x-pw-glass from outside the shadow. We verify
-    # that highlight() and hide_highlight() invoke without error and that
-    # multiple highlights stack on the page.
-    await page.set_content("<button>One</button><button>Two</button>")
-    await page.get_by_role("button", name="One").highlight()
-    await page.get_by_role("button", name="Two").highlight()
-    await expect(page.locator("x-pw-glass")).to_have_count(1)
-    # hide_highlight per-locator and page-level should not raise.
-    await page.get_by_role("button", name="One").hide_highlight()
-    await page.hide_highlight()
-
-
 async def test_get_by_role_with_description(page: Page) -> None:
     # Ported from upstream tests/page/selectors-get-by.spec.ts.
     await page.set_content(
@@ -1363,40 +1348,6 @@ async def texts(locator: Locator) -> list:
     ) == ["Alert 1", "Alert 2"]
 
 
-async def test_get_by_role_with_description_via_aria_describedby(page: Page) -> None:
-    # Ported from upstream tests/page/selectors-get-by.spec.ts.
-    await page.set_content(
-        """
-        <button aria-describedby="desc1">Submit</button>
-        <span id="desc1">Submits the form data</span>
-        <button aria-describedby="desc2">Submit</button>
-        <span id="desc2">Saves as draft</span>
-    """
-    )
-    assert await page.get_by_role(
-        "button", name="Submit", description="form data"
-    ).evaluate_all("els => els.map(e => e.textContent)") == ["Submit"]
-    assert await page.get_by_role(
-        "button", name="Submit", description="draft"
-    ).evaluate_all("els => els.map(e => e.textContent)") == ["Submit"]
-
-
-async def test_get_by_role_with_description_via_title_fallback(page: Page) -> None:
-    # Ported from upstream tests/page/selectors-get-by.spec.ts.
-    await page.set_content(
-        """
-        <button title="Submits the form">Submit</button>
-        <button title="Resets the form">Reset</button>
-    """
-    )
-    assert await page.get_by_role("button", description="Submits").evaluate_all(
-        "els => els.map(e => e.textContent)"
-    ) == ["Submit"]
-    assert await page.get_by_role("button", description="Resets").evaluate_all(
-        "els => els.map(e => e.textContent)"
-    ) == ["Reset"]
-
-
 async def test_get_by_role_with_description_whitespace_normalization(
     page: Page,
 ) -> None:

tests/sync/test_locators.py

@@ -1065,15 +1065,6 @@ def test_drop_should_drop_clipboard_like_data(page: Page) -> None:
     assert info["data"]["text/plain"] == "hello world"
 
 
-def test_highlight_should_attach_a_glass_pane(page: Page) -> None:
-    page.set_content("<button>One</button><button>Two</button>")
-    page.get_by_role("button", name="One").highlight()
-    page.get_by_role("button", name="Two").highlight()
-    expect(page.locator("x-pw-glass")).to_have_count(1)
-    page.get_by_role("button", name="One").hide_highlight()
-    page.hide_highlight()
-
-
 def test_get_by_role_with_description(page: Page) -> None:
     page.set_content(
         """
@@ -1107,20 +1098,6 @@ def texts(locator: Locator) -> list:
     ) == ["Alert 1", "Alert 2"]
 
 
-def test_get_by_role_with_description_via_aria_describedby(page: Page) -> None:
-    page.set_content(
-        """
-        <button aria-describedby="desc1">Submit</button>
-        <span id="desc1">Submits the form data</span>
-        <button aria-describedby="desc2">Submit</button>
-        <span id="desc2">Saves as draft</span>
-    """
-    )
-    assert page.get_by_role(
-        "button", name="Submit", description="form data"
-    ).evaluate_all("els => els.map(e => e.textContent)") == ["Submit"]
-
-
 def test_get_by_role_with_description_whitespace_normalization(page: Page) -> None:
     page.set_content(
         '<div role="alert" aria-description="File  doc-2025.pdf   was uploaded   successfully">Alert</div>'